singhpk234 commented on code in PR #1371:
URL: https://github.com/apache/polaris/pull/1371#discussion_r2059068575
##########
extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcBasePersistenceImpl.java:
##########
@@ -105,9 +113,9 @@ public void writeEntity(
Map<String, Object> params =
Map.of(
"id",
- originalEntity.getId(),
+ entity.getId(),
"catalog_id",
- originalEntity.getCatalogId(),
+ entity.getCatalogId(),
"entity_version",
originalEntity.getEntityVersion(),
Review Comment:
ideally expectation is that the entity and orignal entity have both same
catalog-id and id but the version does require to be orignalEntity's version to
make CAS, it think i should revert the catalog-id and id be extracted from the
orignal entity if it helps in read-ability but from correctness POV this is
right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
