snazy commented on code in PR #1371:
URL: https://github.com/apache/polaris/pull/1371#discussion_r2058498476
##########
quarkus/service/src/test/java/org/apache/polaris/service/quarkus/catalog/IcebergCatalogTest.java:
##########
@@ -1846,4 +1847,28 @@ public void
testConcurrencyConflictUpdateTableDuringFinalTransaction() {
private static InMemoryFileIO getInMemoryIo(IcebergCatalog catalog) {
return (InMemoryFileIO) ((ExceptionMappingFileIO)
catalog.getIo()).getInnerIo();
}
+
+ @Test
+ @Disabled
+ @Override
+ public void createAndDropEmptyNamespace() {
+ // TODO: remove this when quarkus bug :
https://github.com/quarkusio/quarkus/issues/46642
Review Comment:
This is a won't-fix.
You have to tell it to use the Junit5-exception.
Cf
[here](https://github.com/projectnessie/nessie/blob/main/versioned/tests/src/main/java/org/projectnessie/versioned/tests/Junit5Assumptions.java)
and
[here](https://github.com/projectnessie/nessie/blob/main/versioned/tests/src/main/resources/META-INF/services/org.assertj.core.configuration.Configuration)
##########
quarkus/service/src/test/java/org/apache/polaris/service/quarkus/catalog/IcebergCatalogViewTest.java:
##########
@@ -237,4 +234,12 @@ protected Catalog tableCatalog() {
protected boolean requiresNamespaceCreate() {
return true;
}
+
+ @Override
+ @Test
+ @Disabled
+ public void listViewsInEmptyNamespace() {
+ // TODO: remove this when quarkus bug :
https://github.com/quarkusio/quarkus/issues/46642
Review Comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
