singhpk234 commented on code in PR #1371:
URL: https://github.com/apache/polaris/pull/1371#discussion_r2059187659
##########
extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcMetaStoreManagerFactory.java:
##########
@@ -106,12 +107,12 @@ private void initializeForRealm(
}
private DatasourceOperations getDatasourceOperations(boolean isBootstrap) {
- DatasourceOperations databaseOperations = new
DatasourceOperations(dataSource);
+ DatasourceOperations databaseOperations = new
DatasourceOperations(dataSource.get());
if (isBootstrap) {
// TODO: see if we need to take script from Quarkus or can we just
// use the script committed in the repo.
try {
-
databaseOperations.executeScript("scripts/postgres/schema-v1-postgres.sql");
+ databaseOperations.executeScript("postgres/schema-v1-postgresql.sql");
Review Comment:
Follow-up on this :
1. Do we intent to have custom DS per realm or only 1 DS ? was initially
thinking that custom DS name will be name of the realm
https://quarkus.io/guides/datasource#configure-multiple-datasources
2. Type is a bit diff (if we follow convention above) so can't use something
like `quarkus.datasource.postgresql.*`, i think i will have to open a
connection once per DS (may be in the constructor) and then from the connection
get the type and use that to find out which script to use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
