eric-maynard commented on code in PR #1264: URL: https://github.com/apache/polaris/pull/1264#discussion_r2015797148
########## service/common/src/main/java/org/apache/polaris/service/catalog/common/CatalogHandlerWrapper.java: ########## @@ -0,0 +1,349 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.polaris.service.catalog.common; + +import jakarta.ws.rs.core.SecurityContext; +import java.util.Arrays; +import java.util.List; +import java.util.Optional; +import org.apache.iceberg.catalog.Namespace; +import org.apache.iceberg.catalog.TableIdentifier; +import org.apache.iceberg.exceptions.AlreadyExistsException; +import org.apache.iceberg.exceptions.NoSuchNamespaceException; +import org.apache.iceberg.exceptions.NoSuchTableException; +import org.apache.iceberg.exceptions.NoSuchViewException; +import org.apache.polaris.core.PolarisDiagnostics; +import org.apache.polaris.core.auth.AuthenticatedPolarisPrincipal; +import org.apache.polaris.core.auth.PolarisAuthorizableOperation; +import org.apache.polaris.core.auth.PolarisAuthorizer; +import org.apache.polaris.core.catalog.PolarisCatalogHelpers; +import org.apache.polaris.core.context.CallContext; +import org.apache.polaris.core.entity.PolarisEntitySubType; +import org.apache.polaris.core.entity.PolarisEntityType; +import org.apache.polaris.core.persistence.PolarisEntityManager; +import org.apache.polaris.core.persistence.PolarisResolvedPathWrapper; +import org.apache.polaris.core.persistence.resolver.PolarisResolutionManifest; +import org.apache.polaris.core.persistence.resolver.ResolverPath; +import org.apache.polaris.core.persistence.resolver.ResolverStatus; + +public abstract class CatalogHandlerWrapper { + + // Initialized in the authorize methods. + protected PolarisResolutionManifest resolutionManifest = null; + + protected final CallContext callContext; + protected final PolarisEntityManager entityManager; + protected final String catalogName; + protected final AuthenticatedPolarisPrincipal authenticatedPrincipal; + protected final SecurityContext securityContext; + protected final PolarisAuthorizer authorizer; + + public CatalogHandlerWrapper( + CallContext callContext, + PolarisEntityManager entityManager, + SecurityContext securityContext, + String catalogName, + PolarisAuthorizer authorizer) { + this.callContext = callContext; + this.entityManager = entityManager; + this.catalogName = catalogName; + PolarisDiagnostics diagServices = callContext.getPolarisCallContext().getDiagServices(); + diagServices.checkNotNull(securityContext, "null_security_context"); + diagServices.checkNotNull(securityContext.getUserPrincipal(), "null_user_principal"); + diagServices.check( + securityContext.getUserPrincipal() instanceof AuthenticatedPolarisPrincipal, + "invalid_principal_type", + "Principal must be an AuthenticatedPolarisPrincipal"); + this.securityContext = securityContext; + this.authenticatedPrincipal = + (AuthenticatedPolarisPrincipal) securityContext.getUserPrincipal(); + this.authorizer = authorizer; + } + + /** Initialize the catalog once authorized. Called after all `authorize...` methods. */ + protected abstract void initializeCatalog(); + + protected void authorizeBasicNamespaceOperationOrThrow( Review Comment: Below is all directly copy/paste from `IcebergCatalogHandlerWrapper` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
