[
https://jira.codehaus.org/browse/MPMD-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=361653#comment-361653
]
Michael Osipov edited comment on MPMD-199 at 1/22/15 1:38 PM:
--------------------------------------------------------------
Tom, here is my analysis:
* jspReport.apt.vm:
** Please recheck the paragraphs, still refers to JavaScript
** Reduce the POM snippet, there is no need to use a profile or implicit
config, see JS example
** Plugin version is not interpolated but hardcoded
* jsp-configuration-plugin-config.xml:
** Adding PMD again as a plugin dependency seems to be very confusing because
*** This version is ancient
*** PMD is already on the classpath
*** Copy and paste from JS example
Am I wrong here?
The rest is fine though, I will merge as soon as the issue above are clarified.
Speaking of which, I think the add-sources approach is completely ill-designed
in this plugin. It would ultimately add all JSP and JS files to a JAR/WAR
as source which does not make sense at all. This is worth another issue in
JIRA.
was (Author: michael-o):
Tom, here is my analysis:
* jspReport.apt.vm:
* Please recheck the paragraphs, still refers to JavaScript
* Reduce the POM snippet, there is no need to use a profile or implicit
config, see JS example
* Plugin version is not interpolated but hardcoded
* jsp-configuration-plugin-config.xml:
* Adding PMD again as a plugin dependency seems to be very confusing because
* This version is ancient
* PMD is already on the classpath
* Copy and paste from JS example
Am I wrong here?
The rest is fine though, I will merge as soon as the issue above are clarified.
Speaking of which, I think the add-sources approach is completely ill-designed
in this plugin. It would ultimately add all JSP and JS files to a JAR/WAR
as source which does not make sense at all. This is worth another issue in
JIRA.
> Support PMD functionality on JSP files
> --------------------------------------
>
> Key: MPMD-199
> URL: https://jira.codehaus.org/browse/MPMD-199
> Project: Maven PMD Plugin
> Issue Type: Improvement
> Components: PMD
> Affects Versions: 3.3
> Reporter: Tom Williamson
> Priority: Minor
> Attachments: Jsp_support_201501201341.patch,
> JSP_support_201501201523.patch, Patch_for_JSP_support.patch
>
>
> It would be great if this plugin would either support PMD functionality for
> JSP files, or simply enable them as part of the Java support.
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
