[ 
https://jira.codehaus.org/browse/MPMD-199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=361482#comment-361482
 ] 

Michael Osipov commented on MPMD-199:
-------------------------------------

Tom, way better now. A few issues though:

1. {{sample.jsp}} is added twice, ins't it?
2. You copied the javascript apt file to {{jspReport.apt.vm}} but did not alter 
its content.
3. You either need to add the JSP module to the plugins dependencies and/or 
make it optional and tell that actually in the docs.

> Support PMD functionality on JSP files
> --------------------------------------
>
>                 Key: MPMD-199
>                 URL: https://jira.codehaus.org/browse/MPMD-199
>             Project: Maven PMD Plugin
>          Issue Type: Improvement
>          Components: PMD
>    Affects Versions: 3.3
>            Reporter: Tom Williamson
>            Priority: Minor
>         Attachments: Jsp_support_201501201341.patch, 
> Patch_for_JSP_support.patch
>
>
> It would be great if this plugin would either support PMD functionality for 
> JSP files, or simply enable them as part of the Java support.   



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)

Reply via email to