[
https://jira.codehaus.org/browse/MPIR-238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=358077#comment-358077
]
Christian Schulte edited comment on MPIR-238 at 11/26/14 2:26 AM:
------------------------------------------------------------------
I think this issue should be taken care of. It maybe should be filed for Maven
core since the cause of this issue really is a change in behaviour between
Maven 2 and Maven 3. To summarize: In Maven 3, the core got changed to
reference class files from e.g. the 'target/classes' directories in certain
cases. This change stops maven from downloading artifacts from remote
repositories. I think that method {{hasBeenPackaged}} of class
[ReactorReader|https://git-wip-us.apache.org/repos/asf?p=maven.git;a=blob;f=maven-core/src/main/java/org/apache/maven/ReactorReader.java;h=3aca28d17d359b3d5872f89e7cfaa26fa25fcfce;hb=HEAD]
should also check for the artifact to be available in some repository instead
of just checking the package phase. The change I am requesting is to update
method {{hasBeenPackaged}} in a way that it returns {{true}}, if the artifact
being checked is found in a remote repository. For example:
{code}
private boolean hasBeenPackaged( MavenProject project )
{
return project.hasLifecyclePhase( "package" )
|| project.hasLifecyclePhase( "install" )
|| project.hasLifecyclePhase( "deploy" )
|| project artifact can be resolved from a remote repository.
}
{code}
was (Author: schulte2005):
I think this issue should be taken care of. It maybe should be filed for Maven
core since the cause of this issue really is a change in behaviour between
Maven 2 and Maven 3. To summarize: In Maven 3, the core got changed to
reference class files from e.g. the 'target/classes' directories in certain
cases. This change stops maven from downloading artifacts from remote
repositories. I think that method {{hasBeenPackaged}} of class
[ReactorReader|https://git-wip-us.apache.org/repos/asf?p=maven.git;a=blob;f=maven-core/src/main/java/org/apache/maven/ReactorReader.java;h=3aca28d17d359b3d5872f89e7cfaa26fa25fcfce;hb=HEAD]
should also check for the artifact to be available in some repository instead
of just checking the package phase.
> Dependency File Details section of the dependencies report shows
> 'target/classes' for reactor artifacts.
> --------------------------------------------------------------------------------------------------------
>
> Key: MPIR-238
> URL: https://jira.codehaus.org/browse/MPIR-238
> Project: Maven Project Info Reports Plugin
> Issue Type: Bug
> Components: dependency-info
> Affects Versions: 2.4
> Reporter: Christian Schulte
> Priority: Minor
> Attachments: MPIR-238.patch, MPIR-238-ReactorReader.patch,
> MPIR-238-ReactorReader.patch
>
>
> Generating the dependencies report in a multi-module project leads to
> incorrect entries in the 'Dependency File Details' section of the
> dependencies report. For example, the [Maven Release Plugin Dependency File
> Details|http://maven.apache.org/plugins/maven-release-plugin/dependencies.html#Dependency_File_Details]
> report contains the following entry:
> ||Filename||Size||Entries||Classes||Packages||JDK Rev||Debug||
> |maven-release-manager/target/classes|-|0|0|0|-|release|
> Building the site of a single module ('mvn site' in that modules directory),
> the correct entries are shown.
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
