[
https://jira.codehaus.org/browse/MNG-5176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=340329#comment-340329
]
Michael Osipov edited comment on MNG-5176 at 1/29/14 3:04 AM:
--------------------------------------------------------------
Robert, the leading zero makes the minutes consistent. That was intentional and
reasonable. We could evaluate the following two options:
Make [] always same size and pad with whitespace
1.
{noformat}
[1 d 01:10 h]
[ 01:02 h]
[ 01:49 min]
[ 22.345 s]
[ 0.912 s]
{noformat}
2. Left-aligned
{noformat}
[1 d 01:10 h]
[01:02 h ]
[01:49 min ]
[22.345 s ]
[0.912 s ]
{noformat}
or even
3.
{noformat}
[1 d 01:10 h]
[01:02 h]
[01:49 min]
[22.345 s]
[0.912 s]
{noformat}
I'd prefer option one.
Though I strongly doubt that a duration longer than a day will occur very
option, it should be less than 3 %. In this case one could either say {{24
h+}}, {{1.2 d}}, decimal day value or reduce to {{ 1 d 1 h}} since who cares
for the minutes if you build runs longer than a day.
was (Author: michael-o):
Robert, the leading zero makes the minutes consistent. That was intentional and
reasonable. We could evaluate the following two options:
Make [] always same size and pad with whitespace
1.
{noformat}
[1 d 01:10 h]
[ 01:02 h]
[ 01:49 min]
[ 22.345 s]
[ 0.912 s]
{noformat}
2. Left-aligned
{noformat}
[1 d 01:10 h]
[01:02 h ]
[01:49 min ]
[22.345 s ]
[0.912 s ]
{noformat}
or even
3.
{noformat}
[1 d 01:10 h]
[01:02 h]
[01:49 min]
[22.345 s]
[0.912 s]
{noformat}
I'd prefer option one.
Though I strongly doubt that a duration longer than a day will occur very
option, it should be less than 3 %. In this case one could either say {{24 h+}}
or {{1.2 d}}, decimal day value.
> Print build times in an ISO 8601-style manner
> ---------------------------------------------
>
> Key: MNG-5176
> URL: https://jira.codehaus.org/browse/MNG-5176
> Project: Maven 2 & 3
> Issue Type: Improvement
> Components: Logging
> Affects Versions: 2.2.1, 3.0.3
> Environment: Maven 2.2.1 and 3.0.3
> Reporter: Michael Osipov
> Assignee: Michael Osipov
> Fix For: 3.2
>
> Attachments: MNG-5176.patch, MNG-5176.patch
>
>
> The current output of build times is hard to read and does not follow any
> standard. I have patched branch 2.2.x and 3 trunk to follow ISO 8601-style
> date/time formats.
> My patches need less code compared to the current solution. I had the
> following ideas in mind:
> 1. Display times in the same proportional format.
> 2. hour display is fixed to max 24 h as in ISO defined.
> 3. Days are directly integrated, not brain math necessary anymore. Though
> this should be a rare case.
> 3. remove the smallest component if a bigger one is added.
> 4. Easier to parse, predictable output.
> More over, I have changed the finish and total time to ISO too. I did not
> touch the finish time in Maven 2.2.x because it is alphanumeric. I'd rather
> prefer that as total time but this is maybe a matter of taste and harder to
> parse.
> This is a real output:
> {noformat}
> [INFO] Building tar :
> /.amd_mnt/blnn728x/home/osipovmi/Projekte/maven-3/apache-maven/target/apache-maven-3.0.4-SNAPSHOT-bin.tar.gz
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Apache Maven ...................................... SUCCESS [00:04.732]
> [INFO] Maven Model ....................................... SUCCESS [00:06.332]
> [INFO] Maven Artifact .................................... SUCCESS [00:02.551]
> [INFO] Maven Plugin API .................................. SUCCESS [00:03.855]
> [INFO] Maven Model Builder ............................... SUCCESS [00:06.708]
> [INFO] Maven Settings .................................... SUCCESS [00:02.292]
> [INFO] Maven Settings Builder ............................ SUCCESS [00:02.138]
> [INFO] Maven Repository Metadata Model ................... SUCCESS [00:01.931]
> [INFO] Maven Aether Provider ............................. SUCCESS [00:02.442]
> [INFO] Maven Core ........................................ SUCCESS [00:28.509]
> [INFO] Maven Compat ...................................... SUCCESS [00:20.260]
> [INFO] Maven Embedder .................................... SUCCESS [00:03.478]
> [INFO] Maven Distribution ................................ SUCCESS [00:26.715]
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time: 01:52.618
> [INFO] Finished at: 2011-09-19 14:25:24
> [INFO] Final Memory: 36M/144M
> [INFO]
> ------------------------------------------------------------------------
> {noformat}
> A crafted output with all formats would look like this:
> {noformat}
> [INFO] Building tar :
> /.amd_mnt/blnn728x/home/osipovmi/Projekte/maven-3/apache-maven/target/apache-maven-3.0.4-SNAPSHOT-bin.tar.gz
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Apache Maven ...................................... SUCCESS [1 d 03:04]
> [INFO] Maven Model ....................................... SUCCESS [01:00:06]
> [INFO] Maven Artifact .................................... SUCCESS [00:02.551]
> [INFO] Maven Plugin API .................................. SUCCESS [00:03.855]
> [INFO] Maven Model Builder ............................... SUCCESS [00:06.708]
> [INFO] Maven Settings .................................... SUCCESS [00:02.292]
> [INFO] Maven Settings Builder ............................ SUCCESS [00:02.138]
> [INFO] Maven Repository Metadata Model ................... SUCCESS [00:01.931]
> [INFO] Maven Aether Provider ............................. SUCCESS [00:02.442]
> [INFO] Maven Core ........................................ SUCCESS [00:28.509]
> [INFO] Maven Compat ...................................... SUCCESS [00:20.260]
> [INFO] Maven Embedder .................................... SUCCESS [00:03.478]
> [INFO] Maven Distribution ................................ SUCCESS [00:26.715]
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time: 1 d 03:05
> [INFO] Finished at: 2011-09-19 14:25:24
> [INFO] Final Memory: 36M/144M
> [INFO]
> ------------------------------------------------------------------------
> {noformat}
> Since most build are below an hour, they are way easier to read.
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
