[ 
https://jira.codehaus.org/browse/MNG-5176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=340310#comment-340310
 ] 
Michael Osipov edited comment on MNG-5176 at 1/28/14 3:53 PM:
--------------------------------------------------------------

Robert, I have updated the patch and improved the format of the duration a lot.

This is how maven.git looks like
{noformat}
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Apache Maven ...................................... SUCCESS [01:08 min]
[INFO] Maven Model ....................................... SUCCESS [01:06 min]
[INFO] Maven Artifact .................................... SUCCESS [28.000 s]
[INFO] Maven Plugin API .................................. SUCCESS [38.781 s]
[INFO] Maven Model Builder ............................... SUCCESS [52.188 s]
[INFO] Maven Settings .................................... SUCCESS [10.312 s]
[INFO] Maven Settings Builder ............................ SUCCESS [11.969 s]
[INFO] Maven Repository Metadata Model ................... SUCCESS [9.953 s]
[INFO] Maven Aether Provider ............................. SUCCESS [27.547 s]
[INFO] Maven Core ........................................ SUCCESS [01:49 min]
[INFO] Maven Compat ...................................... SUCCESS [01:01 min]
[INFO] Maven Embedder .................................... SUCCESS [24.969 s]
[INFO] Apache Maven Distribution ......................... SUCCESS [38.875 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 09:10 min
[INFO] Finished at: 2014-01-28T22:51:30+01:00
[INFO] Final Memory: 39M/133M
[INFO] ------------------------------------------------------------------------
{noformat}

and this is maven-scm.git
{noformat}
[INFO] Reactor Summary:
[INFO]
[INFO] Apache Maven Wagon ................................ SUCCESS [43.265 s]
[INFO] Apache Maven Wagon :: API ......................... SUCCESS [23.875 s]
[INFO] Apache Maven Wagon :: Provider Test ............... SUCCESS [16.797 s]
[INFO] Apache Maven Wagon :: Providers ................... SUCCESS [12.438 s]
[INFO] Apache Maven Wagon :: Providers :: File Provider .. SUCCESS [12.156 s]
[INFO] Apache Maven Wagon :: Providers :: FTP Provider ... SUCCESS [13.844 s]
[INFO] Apache Maven Wagon :: Providers :: HTTP Shared Library  SUCCESS [11.718 
s]
[INFO] Apache Maven Wagon :: Test Compatibility Kits ..... SUCCESS [7.047 s]
[INFO] Apache Maven Wagon :: HTTP Test Compatibility Kit . SUCCESS [11.016 s]
[INFO] Apache Maven Wagon :: Providers :: HTTP Provider .. SUCCESS [22.687 s]
[INFO] Apache Maven Wagon :: Providers :: Lightweight HTTP Provider  SUCCESS 
[16.828 s]
[INFO] Apache Maven Wagon :: Providers :: SCM Provider ... SUCCESS [31.094 s]
[INFO] Apache Maven Wagon :: Providers :: SSH Common Library  SUCCESS [37.110 s]
[INFO] Apache Maven Wagon :: Providers :: SSH Common Tests  SUCCESS [54.218 s]
[INFO] Apache Maven Wagon :: Providers :: SSH External Provider  SUCCESS 
[40.688 s]
[INFO] Apache Maven Wagon :: Providers :: SSH Provider ... SUCCESS [56.000 s]
[INFO] Apache Maven Wagon :: Providers :: WebDav Provider  SUCCESS [44.625 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 07:37 min
[INFO] Finished at: 2014-01-28T22:46:22+01:00
[INFO] Final Memory: 37M/107M
[INFO] ------------------------------------------------------------------------
{noformat}

Formats are now:

>= 1 d: {{d 'd': %d d hh:mm 'h'}}
>= 1 h: {{hh:mm 'h'}}
>= 1 min: {{mm:ss 'min'}}
else: {{ss.SSS 's'}}

This should be absolutely clear now.
If you have no objections, I will push the patch by the weekend. I'd like to 
have it in 3.2.


was (Author: michael-o):
Robert, I have updated the patch and improved the format of the duration a lot.

This is how maven.git looks like
{noformat}
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Apache Maven ...................................... SUCCESS [01:08 min]
[INFO] Maven Model ....................................... SUCCESS [01:06 min]
[INFO] Maven Artifact .................................... SUCCESS [28.000 s]
[INFO] Maven Plugin API .................................. SUCCESS [38.781 s]
[INFO] Maven Model Builder ............................... SUCCESS [52.188 s]
[INFO] Maven Settings .................................... SUCCESS [10.312 s]
[INFO] Maven Settings Builder ............................ SUCCESS [11.969 s]
[INFO] Maven Repository Metadata Model ................... SUCCESS [9.953 s]
[INFO] Maven Aether Provider ............................. SUCCESS [27.547 s]
[INFO] Maven Core ........................................ SUCCESS [01:49 min]
[INFO] Maven Compat ...................................... SUCCESS [01:01 min]
[INFO] Maven Embedder .................................... SUCCESS [24.969 s]
[INFO] Apache Maven Distribution ......................... SUCCESS [38.875 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 09:10 min
[INFO] Finished at: 2014-01-28T22:51:30+01:00
[INFO] Final Memory: 39M/133M
[INFO] ------------------------------------------------------------------------
{noformat}

and this is maven-scm.git
{noformat}
[INFO] Reactor Summary:
[INFO]
[INFO] Apache Maven Wagon ................................ SUCCESS [43.265 s]
[INFO] Apache Maven Wagon :: API ......................... SUCCESS [23.875 s]
[INFO] Apache Maven Wagon :: Provider Test ............... SUCCESS [16.797 s]
[INFO] Apache Maven Wagon :: Providers ................... SUCCESS [12.438 s]
[INFO] Apache Maven Wagon :: Providers :: File Provider .. SUCCESS [12.156 s]
[INFO] Apache Maven Wagon :: Providers :: FTP Provider ... SUCCESS [13.844 s]
[INFO] Apache Maven Wagon :: Providers :: HTTP Shared Library  SUCCESS [11.718 
s]
[INFO] Apache Maven Wagon :: Test Compatibility Kits ..... SUCCESS [7.047 s]
[INFO] Apache Maven Wagon :: HTTP Test Compatibility Kit . SUCCESS [11.016 s]
[INFO] Apache Maven Wagon :: Providers :: HTTP Provider .. SUCCESS [22.687 s]
[INFO] Apache Maven Wagon :: Providers :: Lightweight HTTP Provider  SUCCESS 
[16.828 s]
[INFO] Apache Maven Wagon :: Providers :: SCM Provider ... SUCCESS [31.094 s]
[INFO] Apache Maven Wagon :: Providers :: SSH Common Library  SUCCESS [37.110 s]
[INFO] Apache Maven Wagon :: Providers :: SSH Common Tests  SUCCESS [54.218 s]
[INFO] Apache Maven Wagon :: Providers :: SSH External Provider  SUCCESS 
[40.688 s]
[INFO] Apache Maven Wagon :: Providers :: SSH Provider ... SUCCESS [56.000 s]
[INFO] Apache Maven Wagon :: Providers :: WebDav Provider  SUCCESS [44.625 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 07:37 min
[INFO] Finished at: 2014-01-28T22:46:22+01:00
[INFO] Final Memory: 37M/107M
[INFO] ------------------------------------------------------------------------
{noformat}

Formats are now:

>= 1 d: d 'd': %d d hh:mm 'h'
>= 1 h: hh:mm 'h'
>= 1 min: mm:ss 'min'
else: ss.SSS 's'

This should be absolutely clear now.
If you have no objections, I will push the patch by the weekend. I have to have 
it in 3.2.

> Print build times in an ISO 8601-style manner
> ---------------------------------------------
>
>                 Key: MNG-5176
>                 URL: https://jira.codehaus.org/browse/MNG-5176
>             Project: Maven 2 & 3
>          Issue Type: Improvement
>          Components: Logging
>    Affects Versions: 2.2.1, 3.0.3
>         Environment: Maven 2.2.1 and 3.0.3
>            Reporter: Michael Osipov
>            Assignee: Michael Osipov
>         Attachments: MNG-5176.patch, MNG-5176.patch
>
>
> The current output of build times is hard to read and does not follow any 
> standard. I have patched branch 2.2.x and 3 trunk to follow ISO 8601-style 
> date/time formats.
> My patches need less code compared to the current solution. I had the 
> following ideas in mind:
> 1. Display times in the same proportional format.
> 2. hour display is fixed to max 24 h as in ISO defined.
> 3. Days are directly integrated, not brain math necessary anymore. Though 
> this should be a rare case.
> 3. remove the smallest component if a bigger one is added.
> 4. Easier to parse, predictable output.
> More over, I have changed the finish and total time to ISO too. I did not 
> touch the finish time in Maven 2.2.x because it is alphanumeric. I'd rather 
> prefer that as total time but this is maybe a matter of taste and harder to 
> parse.
> This is a real output:
> {noformat}
> [INFO] Building tar : 
> /.amd_mnt/blnn728x/home/osipovmi/Projekte/maven-3/apache-maven/target/apache-maven-3.0.4-SNAPSHOT-bin.tar.gz
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Apache Maven ...................................... SUCCESS [00:04.732]
> [INFO] Maven Model ....................................... SUCCESS [00:06.332]
> [INFO] Maven Artifact .................................... SUCCESS [00:02.551]
> [INFO] Maven Plugin API .................................. SUCCESS [00:03.855]
> [INFO] Maven Model Builder ............................... SUCCESS [00:06.708]
> [INFO] Maven Settings .................................... SUCCESS [00:02.292]
> [INFO] Maven Settings Builder ............................ SUCCESS [00:02.138]
> [INFO] Maven Repository Metadata Model ................... SUCCESS [00:01.931]
> [INFO] Maven Aether Provider ............................. SUCCESS [00:02.442]
> [INFO] Maven Core ........................................ SUCCESS [00:28.509]
> [INFO] Maven Compat ...................................... SUCCESS [00:20.260]
> [INFO] Maven Embedder .................................... SUCCESS [00:03.478]
> [INFO] Maven Distribution ................................ SUCCESS [00:26.715]
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 01:52.618
> [INFO] Finished at: 2011-09-19 14:25:24
> [INFO] Final Memory: 36M/144M
> [INFO] 
> ------------------------------------------------------------------------
> {noformat}
> A crafted output with all formats would look like this:
> {noformat}
> [INFO] Building tar : 
> /.amd_mnt/blnn728x/home/osipovmi/Projekte/maven-3/apache-maven/target/apache-maven-3.0.4-SNAPSHOT-bin.tar.gz
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Apache Maven ...................................... SUCCESS [1 d 03:04]
> [INFO] Maven Model ....................................... SUCCESS [01:00:06]
> [INFO] Maven Artifact .................................... SUCCESS [00:02.551]
> [INFO] Maven Plugin API .................................. SUCCESS [00:03.855]
> [INFO] Maven Model Builder ............................... SUCCESS [00:06.708]
> [INFO] Maven Settings .................................... SUCCESS [00:02.292]
> [INFO] Maven Settings Builder ............................ SUCCESS [00:02.138]
> [INFO] Maven Repository Metadata Model ................... SUCCESS [00:01.931]
> [INFO] Maven Aether Provider ............................. SUCCESS [00:02.442]
> [INFO] Maven Core ........................................ SUCCESS [00:28.509]
> [INFO] Maven Compat ...................................... SUCCESS [00:20.260]
> [INFO] Maven Embedder .................................... SUCCESS [00:03.478]
> [INFO] Maven Distribution ................................ SUCCESS [00:26.715]
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 1 d 03:05
> [INFO] Finished at: 2011-09-19 14:25:24
> [INFO] Final Memory: 36M/144M
> [INFO] 
> ------------------------------------------------------------------------
> {noformat}
> Since most build are below an hour, they are way easier to read.



--
This message was sent by Atlassian JIRA
(v6.1.6#6162)

Reply via email to