[
https://jira.codehaus.org/browse/MNG-5176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=338191#comment-338191
]
Michael Osipov commented on MNG-5176:
-------------------------------------
[~rfscholte], I did not strip the zero, I removed the fractional part from the
seconds because this module requires more than one hour to build. The fraction
part are irrelevant in such a scale.
I have already thought about right alignment but where? Align all times to the
right but what about the brackets? Leave spaces? Align with duration? The other
option would be use {{hh:mm:ss.fff}} throughout but that would be a waste of
space because only a little amount of modules really require more than one hour
to build. {{01h00:06}} isn't a good idea because the defined seperator is colon
and nothing else. The alternative is {{01:00:06 h}}, {{02:03.355 min}} but
again you are still wasting space because hour and day is only a small amount.
If you check the first example, you'll see that this looks quite nice. There is
not too much room with ISO 8601, the question simply is: What component does
one want to leave out? As you can see, I left out the least signifiact
component with every order of magnitude.
> Print build times in an ISO 8601-style manner
> ---------------------------------------------
>
> Key: MNG-5176
> URL: https://jira.codehaus.org/browse/MNG-5176
> Project: Maven 2 & 3
> Issue Type: Improvement
> Components: Logging
> Affects Versions: 2.2.1, 3.0.3
> Environment: Maven 2.2.1 and 3.0.3
> Reporter: Michael Osipov
> Assignee: Michael Osipov
> Attachments: MNG-5176.patch
>
>
> The current output of build times is hard to read and does not follow any
> standard. I have patched branch 2.2.x and 3 trunk to follow ISO 8601-style
> date/time formats.
> My patches need less code compared to the current solution. I had the
> following ideas in mind:
> 1. Display times in the same proportional format.
> 2. hour display is fixed to max 24 h as in ISO defined.
> 3. Days are directly integrated, not brain math necessary anymore. Though
> this should be a rare case.
> 3. remove the smallest component if a bigger one is added.
> 4. Easier to parse, predictable output.
> More over, I have changed the finish and total time to ISO too. I did not
> touch the finish time in Maven 2.2.x because it is alphanumeric. I'd rather
> prefer that as total time but this is maybe a matter of taste and harder to
> parse.
> This is a real output:
> {noformat}
> [INFO] Building tar :
> /.amd_mnt/blnn728x/home/osipovmi/Projekte/maven-3/apache-maven/target/apache-maven-3.0.4-SNAPSHOT-bin.tar.gz
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Apache Maven ...................................... SUCCESS [00:04.732]
> [INFO] Maven Model ....................................... SUCCESS [00:06.332]
> [INFO] Maven Artifact .................................... SUCCESS [00:02.551]
> [INFO] Maven Plugin API .................................. SUCCESS [00:03.855]
> [INFO] Maven Model Builder ............................... SUCCESS [00:06.708]
> [INFO] Maven Settings .................................... SUCCESS [00:02.292]
> [INFO] Maven Settings Builder ............................ SUCCESS [00:02.138]
> [INFO] Maven Repository Metadata Model ................... SUCCESS [00:01.931]
> [INFO] Maven Aether Provider ............................. SUCCESS [00:02.442]
> [INFO] Maven Core ........................................ SUCCESS [00:28.509]
> [INFO] Maven Compat ...................................... SUCCESS [00:20.260]
> [INFO] Maven Embedder .................................... SUCCESS [00:03.478]
> [INFO] Maven Distribution ................................ SUCCESS [00:26.715]
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time: 01:52.618
> [INFO] Finished at: 2011-09-19 14:25:24
> [INFO] Final Memory: 36M/144M
> [INFO]
> ------------------------------------------------------------------------
> {noformat}
> A crafted output with all formats would look like this:
> {noformat}
> [INFO] Building tar :
> /.amd_mnt/blnn728x/home/osipovmi/Projekte/maven-3/apache-maven/target/apache-maven-3.0.4-SNAPSHOT-bin.tar.gz
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Apache Maven ...................................... SUCCESS [1 d 03:04]
> [INFO] Maven Model ....................................... SUCCESS [01:00:06]
> [INFO] Maven Artifact .................................... SUCCESS [00:02.551]
> [INFO] Maven Plugin API .................................. SUCCESS [00:03.855]
> [INFO] Maven Model Builder ............................... SUCCESS [00:06.708]
> [INFO] Maven Settings .................................... SUCCESS [00:02.292]
> [INFO] Maven Settings Builder ............................ SUCCESS [00:02.138]
> [INFO] Maven Repository Metadata Model ................... SUCCESS [00:01.931]
> [INFO] Maven Aether Provider ............................. SUCCESS [00:02.442]
> [INFO] Maven Core ........................................ SUCCESS [00:28.509]
> [INFO] Maven Compat ...................................... SUCCESS [00:20.260]
> [INFO] Maven Embedder .................................... SUCCESS [00:03.478]
> [INFO] Maven Distribution ................................ SUCCESS [00:26.715]
> [INFO]
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO]
> ------------------------------------------------------------------------
> [INFO] Total time: 1 d 03:05
> [INFO] Finished at: 2011-09-19 14:25:24
> [INFO] Final Memory: 36M/144M
> [INFO]
> ------------------------------------------------------------------------
> {noformat}
> Since most build are below an hour, they are way easier to read.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
