Move Parser.JUSTIFY_* over to Sink interface
--------------------------------------------
Key: DOXIA-248
URL: http://jira.codehaus.org/browse/DOXIA-248
Project: Maven Doxia
Issue Type: Wish
Components: Core, Sink API
Affects Versions: 1.0-beta-1
Reporter: Benjamin Bentmann
Attachments: table-cell-justify.patch
While implementing a Maven report plugin, I called {{Sink.tableRows(int[],
boolean)}}. Searching for the constants required to specify the cell
justifications, I ended up importing {{Parser}} from doxia-core...
I am not convinced that this design is appropriate. Sure, parsers will usually
require access to these constants but this can be generalized to every client
that communicates with a sink, in particular a Maven report generator which is
completely unrelated to parsing. IMHO, these constants play just the same role
as the {{SinkEventAttributes}} and as such should be part of doxia-sink-api to
make the Sink API self-contained.
I am well aware that this will break compilation of code that migrates from
Doxia alpha to beta but that should be legal for an alpha. At runtime, the
change won't cause troubles since the compiler must inline constants and as
such there is no effective dependency in the bytecode on the old constants in
{{Parser}}.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
