kwin commented on code in PR #2236:
URL: https://github.com/apache/maven-resolver/pull/2236#discussion_r4388688935
##########
maven-resolver-test-http/pom.xml:
##########
@@ -115,9 +115,11 @@
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
</dependency>
+ <!-- used to capture log events -->
<dependency>
- <groupId>org.slf4j</groupId>
- <artifactId>slf4j-simple</artifactId>
+ <groupId>ch.qos.logback</groupId>
+ <artifactId>logback-classic</artifactId>
+ <version>1.5.32</version>
Review Comment:
This is clearly not true, all dependencies only used once are declared with
version only in the module they are used in, e.g.
maven-resolver-transport-apache/pom.xml:
```
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpclient</artifactId>
<version>4.5.14</version>
```
This is the same pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
