gnodet-bot commented on code in PR #2236:
URL: https://github.com/apache/maven-resolver/pull/2236#discussion_r4389326644
##########
maven-resolver-api/src/main/java/org/eclipse/aether/ConfigurationProperties.java:
##########
@@ -399,17 +400,16 @@ public enum RedirectMode {
public static final String HTTP_RETRY_HANDLER_INTERVAL =
PREFIX_TRANSPORT_HTTP + "retryHandler.interval";
/**
- * The default initial retry interval to use if {@link
#HTTP_RETRY_HANDLER_INTERVAL} isn't set.
+ * The default initial retry delay to use if {@link
#HTTP_RETRY_HANDLER_INTERVAL} isn't set.
* Default value 5000ms.
*
* @since 1.9.16
*/
public static final long DEFAULT_HTTP_RETRY_HANDLER_INTERVAL = 5000L;
/**
- * The maximum retry interval in millis of request to a remote server
above which the request should be aborted
- * instead. In theory, a malicious server could tell Maven "come back
after 100 years" that would stall the build
- * for some. Using this parameter Maven will fail the request instead, if
interval is above this value.
+ * The maximum delay in milliseconds for retried requests. Every delay is
capped to this value.
Review Comment:
📝 **Nit — trailing whitespace** after the period on this line.
```suggestion
* The maximum delay in milliseconds for retried requests. Every delay
is capped to this value.
```
##########
maven-resolver-api/src/main/java/org/eclipse/aether/ConfigurationProperties.java:
##########
@@ -386,9 +386,10 @@ public enum RedirectMode {
public static final int DEFAULT_HTTP_RETRY_HANDLER_COUNT = 3;
/**
- * The initial retry interval in millis of request to a remote server
should be waited in case of
+ * The initial delay in milliseconds for retried request after receiving a
response from remote server with HTTP codes
* "too many requests" (HTTP codes 429 and 503). Accepts long as
milliseconds. This value is used if remote server
Review Comment:
📝 **Nit — grammar and redundancy:** "retried request" should be plural
("retried requests"), and the phrase "with HTTP codes" at the end of line 389
is redundant with "(HTTP codes 429 and 503)" at the start of line 390, creating
an awkward read.
```suggestion
* The initial delay in milliseconds for retried requests after
receiving a server response with status
* "too many requests" (HTTP codes 429 and 503). Accepts long as
milliseconds. This value is used if the remote server
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
