Yashisinghal285 commented on code in PR #13447:
URL: https://github.com/apache/maven/pull/13447#discussion_r4251647681
##########
apache-maven/src/assembly/maven/bin/mvn:
##########
@@ -398,13 +398,20 @@ concat_lines() {
}
# Run the parser using source-launch mode
- # Capture both stdout and stderr for comprehensive error reporting
- parser_output=$("$JAVACMD" "$MAVEN_HOME/bin/JvmConfigParser.java" "$1"
"$MAVEN_PROJECTBASEDIR_NATIVE" 2>&1)
+ # Capture stdout for JVM options; capture stderr separately so JVM notices
Review Comment:
Added a signal trap on EXIT INT TERM to ensure temporary files are cleaned
up on interruption or exit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
