[
http://jira.codehaus.org/browse/MPLUGIN-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_124395
]
bentmann edited comment on MPLUGIN-76 at 2/19/08 5:11 PM:
-------------------------------------------------------------------
Well, in the end, it's quit the same code, i.e. an OutputStreamWriter on top of
a FileOutputStream. What I don't like about {{WriterFactory.newWriter()}} is
that its method signature ony returns a {{Writer}} though it could have been
declared to return {{OutputStreamWriter}} which is a little more convenient in
use (especially it offers {{getEncoding()}}). For some funny thing,
{{WriterFactory.newXmlWriter()}} does not return only {{Writer}}...
was (Author: bentmann):
Well, in the end, it's quit the same code, i.e. an OutputStreamWriter on
top of a FileOutputStream. What I don't like about {{WriterFactory.newWriter()}
is that its method signature ony returns a {{Writer}} though it could have been
declared to return {{OutputStreamWriter}} which is a little more convenient in
use (especially it offers {{getEncoding()}}). For some funny thing,
{{WriterFactory.newXmlWriter()}} does not return only {{Writer}}...
> Fixed file encoding employed by PluginXDocGenerator
> ---------------------------------------------------
>
> Key: MPLUGIN-76
> URL: http://jira.codehaus.org/browse/MPLUGIN-76
> Project: Maven 2.x Plugin Tools
> Issue Type: Bug
> Components: API
> Affects Versions: 2.3
> Reporter: Benjamin Bentmann
> Attachments: file-encoding.patch
>
>
> The class currenlty uses the platform's default encoding (say ISO-8859-1) to
> write a XML file without a XML declaration such that readers will assume
> UTF-8 instead. The patch enforces UTF-8 output and (as a best practice) adds
> the XML declaration to the output file.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
