adangel commented on PR #728: URL: https://github.com/apache/maven-pmd-plugin/pull/728#issuecomment-5616609620
So, this is really addressing a edge case here: Only when using maven4 (and you naturally run with java 17+ then) and want to analyze a java project, that uses e.g. java 8 or 11. In that case, you run into the problem with toolchains. The solution here makes the whole plugin a bit more fragile - and the logging also doesn't work anymore. Is it worth to support this edge case? With #726, the project can remove the toolchain plugin/configuration and PMD will run in the same JVM as maven (without forking) but still use the correct toolchain for type resolution. (See https://github.com/adangel/scratchpad/tree/auxclasspath-java-runtime). This requires an update of the project configuration, when they switch to maven4. The current integration test (MPMD-304-toolchain-support) can be fixed easily by just using java 17 instead of 11... @Bukama @slachiewicz What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
