ascheman commented on PR #13078: URL: https://github.com/apache/maven/pull/13078#issuecomment-5597927922
@cstamas — the SNAPSHOT and IT-explosion questions are resolved on my side (thanks, and to @gnodet for #2133). One code point from the validation consolidation itself, independent of the IT fix: The removed `DefaultMetadataReader.validateMetadata()` validated **both** `plugin.getArtifactId()` and `plugin.getPrefix()`, but the consolidated `ValidatingMetadataXpp3Reader.validate()` adds only `plugin.getArtifactId()` — `getPrefix()` is no longer validated. Since the plugin prefix is carried forward as a coordinate/path component (the old reader's comment flagged prefixes as such), is dropping its validation intentional, or should it get a `PathUtils.validatePathComponent(plugin.getPrefix(), "plugin/prefix")` alongside the artifactId? Two minors: `validate()` went `public` → `private` (fine — internal package, no external caller left), and there's no test yet exercising the plugin-token validation path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
