gnodet commented on PR #13078: URL: https://github.com/apache/maven/pull/13078#issuecomment-5588289822
Updated the resolver fix PR based on @cstamas's analysis. The first fix only handled legacy `nid` → `nid_hurl` migration, but the real problem is different: **The ITs override `central` to `file:target/null`** to prevent remote access. With `nid_hurl`, the tracking key includes a hash of the repo URL: `central-<sha1(https://repo.maven.apache.org/maven2)>` ≠ `central-<sha1(file:target/null)>`. Same repo ID, different URL hash → tracking key mismatch → artifact treated as "present but unavailable" → tries to download from `file:target/null` → 💥 The fix now has a two-stage fallback: 1. **Stage 1**: ID-only match (handles legacy `nid` entries from older resolvers) 2. **Stage 2**: repo-ID prefix match (handles same-id-different-URL `nid_hurl` entries — the IT scenario) This effectively relaxes f013 to recording-only: entries are written with URL-qualified keys, but lookups fall back to repo-ID matching. All 585 resolver tests pass. Fix PR: https://github.com/apache/maven-resolver/pull/2133 (force-pushed with the updated fix) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
