fridrich opened a new pull request, #12887: URL: https://github.com/apache/maven/pull/12887
When working on https://github.com/apache/maven/pull/12871 I realized that there are several unused configuration files and tests some dating from the beginning of this century. So, I made this follow-up commit removing all stuff that is not referenced anywhere. It included even a hardcoded user path on his Mac and several snippets that can mislead someone that is grepping for best practices. I run the fix through integration tests in embedded and in forked mode, with mimir and without mimir and every time I run them twice, just to be sure there is nothing bombing out on already existing files. The first commit is the actual removal the second commit is the renaming of the tests. So that if one removes test 2 and leaves test 3, there is no gap in the numbering. The diff might be somehow confusing in the renumbering commit, because some tests were bit-to-bit copies, just with different settings.xml. Following this checklist to help us incorporate your contribution quickly and easily: - [x] Your pull request should address just one issue, without pulling in other changes. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that commits might be squashed by a maintainer on merge. - [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible but is a best-practice. - [x] Run `mvn verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
