slachiewicz opened a new pull request, #238:
URL: https://github.com/apache/maven-changelog-plugin/pull/238
Supersedes #237, which bumped `doxiaVersion` alone and failed: Doxia 2.x no
longer ships the legacy `org.codehaus.doxia.sink.Sink` still referenced by
`maven-reporting-api` 3.x, so every report test died with
`NoClassDefFoundError: org/codehaus/doxia/sink/Sink`. The Doxia bump cannot be
done without moving `maven-reporting-impl` along with it.
### pom
* `doxiaVersion` 1.11.1 → 2.1.0
* `maven-reporting-impl` 3.1.0 → **4.0.0** — the version already used by
maven-site-plugin 3.22.0 and the sibling reporting plugins
* the Doxia artifacts inherited from `maven-reporting-impl` (`doxia-core`,
`doxia-module-apt`, `doxia-module-xdoc`, `doxia-site-model`,
`doxia-integration-tools`) are pinned to `${doxiaVersion}` in
`dependencyManagement`; without that, `doxia-site-model` 2.0.0 is mixed with
`doxia-site-renderer` 2.1.0 and rendering fails with `NoSuchMethodError:
SiteModel.getMermaid()`
* dropped the `plexus-container-default` exclusions, obsolete with Doxia 2.x
(the `ensure-no-container-api` enforcer rule still passes)
### main code
`AbstractMavenReport` 4.x reads its own `protected project` field directly,
so the shadowing copy in `ChangeLogReport` (and its `getProject()` override) is
removed - otherwise the field stays null and site rendering fails with `project
cannot be null`.
### tests
`AbstractMavenReport.execute()` is `final` since 4.0.0 and renders a full
site page when the report runs as a standalone goal, which needs a usable
repository session to resolve the site skin. The new
`AbstractChangeLogReportTest` sets one up, following what
maven-checkstyle-plugin already does, and `siteDirectory` is pointed at an
empty directory so that the default site descriptor is used - this plugin's own
`src/site/site.xml` declares no `<skin>`. Test-scoped
`maven-resolver-connector-basic` and `maven-resolver-transport-http` are added
so the skin can actually be downloaded.
### verification
`mvn -P run-its verify` is green: 23 unit tests, all 4 ITs,
`dependency:analyze` and all enforcer rules including the Java 8 bytecode
check. `mvn site` renders with Fluido 2.1.0, and the IT-generated
`changelog.html`, `dev-activity.html` and `file-activity.html` have the
expected content.
Note that the report unit tests now need network access to fetch the site
skin into `target/local-repo`, same as the maven-checkstyle-plugin report tests.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
