gnodet opened a new pull request, #12647: URL: https://github.com/apache/maven/pull/12647
## Summary - Routes structured validation problems from 4 pathways (settings, toolchains, model validation, graph building) into `DefaultDiagnosticCollector` so they appear in the build report with full `key`/`suggestion`/`documentationUrl` metadata - Converts compat `ModelProblem` objects to Maven 4 `BuilderProblem` API via `toBuilderProblem()` converters in `DefaultProjectsSelector` and `DefaultMaven` - Adds `EXCLUDED_LOGGERS` set in `BuildReportCollector` to prevent double-counting when the same problems are both piped structurally and logged via SLF4J - Migrates all test files from `DefaultBuilderProblem` constructor to `BuilderProblem.builder()` API ### Pathways piped | # | Location | Source | |---|----------|--------| | 1 | `DefaultProjectsSelector` | Model validation problems | | 2 | `DefaultMaven.buildGraph()` | Graph building problems | | 3 | `LookupInvoker` | Settings validation problems | | 4 | `MavenInvoker` | Toolchains validation problems | Pathway 5 (`DefaultPluginValidationManager`) is intentionally deferred — it has a separate complex pipeline. ## Test plan - [x] `DefaultDiagnosticCollectorTest` — 16 tests pass - [x] `BuildReportCollectorTest` — 13 tests pass - [x] `BuildReportIntegrationTest` — 4 tests pass - [x] `BuildReportJsonWriterTest` — 9 tests pass - [x] `DefaultGraphBuilderTest` — 34 tests pass (updated constructor call) Depends on #12572 (Build Report Foundation). 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
