Hiteshsai007 opened a new pull request, #12546:
URL: https://github.com/apache/maven/pull/12546
The launcher already converted POSIX paths to their native Windows form for
Cygwin and MinGW (GH-7958), but a few paths still reached the JVM in a mangled
or mixed form:
* uname(1) reports MSYS_NT-* for the MSYS2 shell, which did not match the
MINGW* pattern, so no conversion happened at all there. The MSYS2 argument
conversion then rewrote the POSIX path into the mixed form D:/a/... instead of
D:\a\...
* ${MAVEN_PROJECTBASEDIR} placeholders in .mvn/jvm.config were expanded with
the POSIX path, since JvmConfigParser was invoked before the conversion took
place. The base directory is now converted upfront and both representations are
kept: the POSIX one to locate jvm.config from the shell, the native one for
everything handed over to the JVM.
* -Dlibrary.jline.path was built by appending /lib/jline-native to the
already converted MAVEN_HOME, producing C:\maven/lib/jline-native. It is now
converted on its own.
Additionally, the output of JvmConfigParser and of the base directory lookup
is printed with printf instead of echo. Several POSIX shells (dash and other
Almquist derivatives commonly installed as /bin/sh) expand backslash escapes in
echo, which corrupts Windows paths, and the conversion is guarded so a missing
cygpath(1) warns and falls back to POSIX paths rather than passing empty paths
to the JVM.
A shell test covering all of the above is added; it stubs uname, cygpath and
java so the Windows-only code paths can be exercised on any platform, and it
can be run on any platform or wired into CI.
Fixes GH-12537
<!--
Please open pull requests against one of the following branches:
- master — default target for all changes (new features + bug fixes).
If the change should also go to maven-4.0.x, request a backport in the PR.
- maven-3.10.x — target for 3.x changes (new features + bug fixes).
If the change should also go to maven-3.9.x, request a backport in the PR.
maven-3.9.x should receive only serious bug fixes, as it is approaching
EOL.
Backports are typically handled by maintainers;
however, after agreement you may open a separate backport PR to the target
maintenance branch.
-->
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Your pull request should address just one issue, without pulling in
other changes.
- [x] Write a pull request description that is detailed enough to understand
what the pull request does, how, and why.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
Note that commits might be squashed by a maintainer on merge.
- [x] Write unit tests that match behavioral changes, where the tests fail
if the changes to the runtime are not applied.
This may not always be possible but is a best-practice.
- [x] Run `mvn verify` to make sure basic checks pass.
A more thorough check will be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
