desruisseaux commented on code in PR #11702:
URL: https://github.com/apache/maven/pull/11702#discussion_r2798557908


##########
impl/maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java:
##########
@@ -693,27 +693,27 @@ private void initProject(MavenProject project, 
ModelBuilderResult result) {
 
                 /*
                  * `sourceDirectory`, `testSourceDirectory` and 
`scriptSourceDirectory`
-                 * are ignored if the POM file contains at least one enabled 
<source> element
+                 * are not used if the POM file contains at least one enabled 
<source> element

Review Comment:
   Yes, when the `<module>` element is not used I think that we can continue to 
use the legacy directories.
   
   Regarding the default values specified in the super POM, I suggest to not do 
any change for now (we may revisit in some future version). The default values 
of `<source>` elements are implemented in Java code for now, and they are 
designed in such a way that, when no `<module>` element is used, they match the 
default values of the super POM.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to