rmannibucau commented on code in PR #1027:
URL:
https://github.com/apache/maven-compiler-plugin/pull/1027#discussion_r2755047410
##########
src/main/java/org/apache/maven/plugin/compiler/ToolExecutor.java:
##########
@@ -72,11 +73,6 @@
* @author Martin Desruisseaux
*/
public class ToolExecutor {
- /**
- * The locale for diagnostics, or {@code null} for the platform default.
- */
- private static final Locale LOCALE = null;
-
Review Comment:
I didnt say it was buggy but it looks like that - was my first thought
checking the code.
> if someone puts a value different then null, it will be taken in account
then it will be a bug so we must not do it, it can be acceptable to make it
not static but it would stay dead code cause it is never written - doesn't idea
warns about it btw, it should?
So think it is really safer and saner to not do it until we do it cleanly
cause it will also require to handle locale configuration and think about doing
it globally or per execution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
