desruisseaux commented on code in PR #1027:
URL:
https://github.com/apache/maven-compiler-plugin/pull/1027#discussion_r2756379360
##########
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##########
@@ -885,6 +885,16 @@ final void
amendincrementalCompilation(EnumSet<IncrementalBuild.Aspect> aspects,
@Parameter(property = "maven.compiler.maxmem")
protected String maxmem;
+ /**
+ * Should maven log a summary of compiler messages (if any) by type.
+ * When there are a lot of messages of the same type (unchecked,
deprecation etc),
+ * it can make the output more readable.
+ *
+ * @since 4.0.0-beta-5
+ */
+ @Parameter(property = "maven.compiler.messageLogType", defaultValue =
"COMPILER")
+ protected MessageLogType messageLogType;
+
Review Comment:
> filtering for a logger is only the level
In `java.util.logging`, filtering is also by logger name. Filtering is also
by handler (different filtering for logs sent to the console or logs sent to a
file). I never use SLF4J, but I presume that it has the same capability than
`java.util.logging`. If we use system logging, it will delegate either to
`java.util.logging` (default), or to SLF4J, therefore is would have this
capability as well.
> also think we should stick to logger=class
`java.util.logging` uses a more generic term, "subsystem", with a
recommendation to base it on the package name or class name. In other words,
the logger name should indeed starts at least with the package name, but there
is some flexibility for what come after the package name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
