desruisseaux commented on code in PR #1027:
URL:
https://github.com/apache/maven-compiler-plugin/pull/1027#discussion_r2753937790
##########
src/main/java/org/apache/maven/plugin/compiler/ToolExecutor.java:
##########
@@ -72,11 +73,6 @@
* @author Martin Desruisseaux
*/
public class ToolExecutor {
- /**
- * The locale for diagnostics, or {@code null} for the platform default.
- */
- private static final Locale LOCALE = null;
-
Review Comment:
It is neither buggy nor misleading. It is supported: if someone puts a value
different then null, it will be taken in account. The fact that it is `static
final` clearly indicates that it is not configurable yet. It is not dead code,
it is a constant in the same was as if we defined a constant of 0. Please
revert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
