rmannibucau commented on code in PR #1027:
URL:
https://github.com/apache/maven-compiler-plugin/pull/1027#discussion_r2753856738
##########
src/main/java/org/apache/maven/plugin/compiler/AbstractCompilerMojo.java:
##########
@@ -885,6 +885,16 @@ final void
amendincrementalCompilation(EnumSet<IncrementalBuild.Aspect> aspects,
@Parameter(property = "maven.compiler.maxmem")
protected String maxmem;
+ /**
+ * Should maven log a summary of compiler messages (if any) by type.
+ * When there are a lot of messages of the same type (unchecked,
deprecation etc),
+ * it can make the output more readable.
+ *
+ * @since 4.0.0-beta-5
+ */
+ @Parameter(property = "maven.compiler.messageLogType", defaultValue =
"COMPILER")
+ protected MessageLogType messageLogType;
+
Review Comment:
I thought about that and rational was that this is a behavior you want to
have and not logger related, this is closer to an "output format" than a
channel with a log level. Also think it would be a bad practise to abuse logger
as we did abuse type in terms of design cause loggers are intended for output
management and not for output formatting/content selection primarily - even if
we can always workaround things.
so think we are good this way
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
