elharo commented on code in PR #11568:
URL: https://github.com/apache/maven/pull/11568#discussion_r2645570360
##########
impl/maven-impl/src/main/java/org/apache/maven/api/services/model/UrlNormalizer.java:
##########
@@ -18,6 +18,17 @@
*/
package org.apache.maven.api.services.model;
+/**
Review Comment:
since there is an interface, there is a possibility that a different
implementation will do something different. Is this planned or intended? If
not, we really should collapse this to a single class.
##########
impl/maven-impl/src/main/java/org/apache/maven/api/services/model/UrlNormalizer.java:
##########
@@ -18,6 +18,17 @@
*/
package org.apache.maven.api.services.model;
+/**
+ * Simplifies URLs by removing parent directory references ("/../") and
collapsing path segments.
Review Comment:
I wonder if this comment belongs on the method rather than or in addition to
the class so it will appear in IDE tooltips when I hover over an invocation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
