elharo commented on code in PR #11568:
URL: https://github.com/apache/maven/pull/11568#discussion_r2627495802
##########
impl/maven-impl/src/main/java/org/apache/maven/api/services/model/UrlNormalizer.java:
##########
@@ -18,6 +18,18 @@
*/
package org.apache.maven.api.services.model;
+/**
+ * Provide a service of {@link UrlNormalizer} that simplifies URL strings by
removing parent directory
+ * references ("/../") and collapsing path segments. This implementation
performs purely
Review Comment:
This is an interface, not an implementation
##########
impl/maven-impl/src/main/java/org/apache/maven/api/services/model/UrlNormalizer.java:
##########
@@ -18,6 +18,18 @@
*/
package org.apache.maven.api.services.model;
+/**
+ * Provide a service of {@link UrlNormalizer} that simplifies URL strings by
removing parent directory
Review Comment:
This isn't really a "service" as that word is often used in software
development these days. It's just an interface.
"Provide a service of {@link UrlNormalizer} that simplifies URL strings" -->
Simplifies URLs
##########
impl/maven-impl/src/main/java/org/apache/maven/api/services/model/UrlNormalizer.java:
##########
@@ -18,6 +18,18 @@
*/
package org.apache.maven.api.services.model;
+/**
+ * Provide a service of {@link UrlNormalizer} that simplifies URL strings by
removing parent directory
+ * references ("/../") and collapsing path segments. This implementation
performs purely
+ * string-based normalization without full URL parsing or validation.
+ *
+ * <p>The normalization process iteratively removes "/../" segments by
eliminating the preceding path segment,
+ * effectively resolving relative path traversals.
+ *
+ * <p>Note that this implementation does not guarantee that the resulting URL
is valid or reachable; it simply
Review Comment:
Note that this implementation does not --> This does not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
