erik-meuwese-topicus commented on code in PR #416: URL: https://github.com/apache/maven-build-cache-extension/pull/416#discussion_r2596339515
########## src/test/projects/reconcile-expressions/.mvn/extensions.xml: ########## @@ -0,0 +1,25 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + + Copyright 2021 the original author or authors. + + Licensed under the Apache License, Version 2.0 (the "License"); + you may not use this file except in compliance with the License. + You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. + +--> +<extensions> + <extension> + <groupId>org.apache.maven.extensions</groupId> + <artifactId>maven-build-cache-extension</artifactId> + <version>${projectVersion}</version> + </extension> Review Comment: XML shoud have 2 space indents to minimize diffs when others use the code style formatter https://maven.apache.org/developers/conventions/code.html ########## src/test/projects/reconcile-expressions/.mvn/maven-build-cache-config.xml: ########## @@ -0,0 +1,53 @@ +<?xml version="1.0" encoding="UTF-8" ?> + +<!-- +Licensed to the Apache Software Foundation (ASF) under one +or more contributor license agreements. See the NOTICE file +distributed with this work for additional information +regarding copyright ownership. The ASF licenses this file +to you under the Apache License, Version 2.0 (the +"License"); you may not use this file except in compliance +with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, +software distributed under the License is distributed on an +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +KIND, either express or implied. See the License for the +specific language governing permissions and limitations +under the License. +--> + +<cache xmlns="http://maven.apache.org/BUILD-CACHE-CONFIG/1.3.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/BUILD-CACHE-CONFIG/1.3.0 https://maven.apache.org/xsd/build-cache-config-1.3.0.xsd";> + + <executionControl> + <reconcile> + <plugins> + <!-- Test expression reconciliation for resources plugin --> + <plugin goal="resources" artifactId="maven-resources-plugin" groupId="org.apache.maven.plugins"> + <reconciles> + <!-- Test with project.version expression --> + <reconcile propertyName="project.version" expression="${project.version}"/> + <!-- Test with custom property expression --> + <reconcile propertyName="product.name" expression="${product.name}"/> + <!-- Test with build environment property --> + <reconcile propertyName="build.environment" expression="${build.environment}"/> + </reconciles> + </plugin> + <!-- Test expression reconciliation for compiler plugin --> + <plugin goal="compile" artifactId="maven-compiler-plugin" groupId="org.apache.maven.plugins"> + <reconciles> + <!-- Test with project groupId expression --> + <reconcile propertyName="project.groupId" expression="${project.groupId}"/> + <!-- Test with project artifactId expression --> + <reconcile propertyName="project.artifactId" expression="${project.artifactId}"/> + <!-- Test with combined expression using multiple properties --> + <reconcile propertyName="custom.timestamp" expression="${custom.timestamp}"/> + </reconciles> + </plugin> + </plugins> + </reconcile> + </executionControl> Review Comment: XML shoud have 2 space indents to minimize diffs when others use the code style formatter https://maven.apache.org/developers/conventions/code.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
