pdudits commented on code in PR #416:
URL:
https://github.com/apache/maven-build-cache-extension/pull/416#discussion_r2611124718
##########
src/main/java/org/apache/maven/buildcache/xml/DtoUtils.java:
##########
@@ -109,14 +114,11 @@ public static Dependency createDependency(Artifact
artifact) {
}
public static void addProperty(
- CompletedExecution execution, String propertyName, Object value,
String baseDirPath, boolean tracked) {
+ CompletedExecution execution, String propertyName, Object value,
Path baseDirPath, boolean tracked) {
Review Comment:
> How do you know you've replaced all usages? They are not necessarily in
this repo.
Hence the question. I couldn't imagine a third-party code depending on
utility method that modifies internal state of Maven extension (unless it's a
fork, of course in which case they are better of migrating to new method
anyway). But people closer to this project may be better informed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
