Pankraz76 commented on code in PR #2367:
URL: https://github.com/apache/maven/pull/2367#discussion_r2100180995
##########
compat/maven-compat/src/test/java/org/apache/maven/repository/legacy/resolver/DefaultArtifactCollectorTest.java:
##########
@@ -293,10 +293,9 @@ void testResolveNearestWithRanges() throws
ArtifactResolutionException, InvalidV
}
@Test
- @SuppressWarnings("checkstyle:UnusedLocalVariable")
void testResolveRangeWithManagedVersion() throws
ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec a = createArtifactSpec("a", "1.0");
- ArtifactSpec b = a.addDependency("b", "[1.0,3.0]");
Review Comment:
yes, this is unit lvl and can be modified if needed of just give watch. We
all extract code into snippets when debugging, but only then. 9 out of 10 its
reading the code. Once its running, debug mode is the exception.
Therefore should be cleaned up to meet out standards.
Same reasoning applies to any code to we dont leave this raw as well so it
seems inconsequent imho.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
