[
http://jira.codehaus.org/browse/MWAR-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephane Nicoll reopened MWAR-104:
----------------------------------
Sorry Olivier, I finally had the time to look into details before calling a
vote for 2.1-alpha-1 and there is a couple of problems.
1. Missing overlay's type
There is no way to define the type of the overlay so your implementation takes
the assumption that there will be no clash between war artifacts and zip
artifacts. I know it sounds a bit tricky but we should stick to the dependency
mechanism properly. So we should add a "type" attribute for the overlay and
retrieve the Artifact in the OverlayManager using this property *which defaults
to war* (hence, for a war, there is no type attribute to set).
2. Zip handling
I don't like your implementation when you update the "this.overlays" list. This
list should not be updated there, it's the best way to have inconsistencies
when we'll upgrade the code. I understand that you had to do this to disable
the behavior by default.
1 is a must have because if we do it later, it will break for users updating
(type will suddenly be necessary for zip overlays). If you are conformable with
the idea and have time, do it. If you don't, I'll do it but I have a real free
time issue now I'm teaching.
> handle zip dependencies in war plugin
> -------------------------------------
>
> Key: MWAR-104
> URL: http://jira.codehaus.org/browse/MWAR-104
> Project: Maven 2.x War Plugin
> Issue Type: Improvement
> Environment: all
> Reporter: Olivier Lamy
> Assignee: Olivier Lamy
> Fix For: 2.1-alpha-1
>
> Attachments: foobar.zip, MWAR-104
>
>
> As MNG-1683 has been applied, the zip artifact must be handled in the war
> plugin.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
