hgschmie commented on code in PR #2331: URL: https://github.com/apache/maven/pull/2331#discussion_r2096568137
########## .pmd/exclude.properties: ########## @@ -0,0 +1,483 @@ +org.apache.maven.AbstractMavenLifecycleParticipant=AbstractClassWithoutAbstractMethod +org.apache.maven.DefaultArtifactFilterManager=MissingOverride +org.apache.maven.DefaultMaven=GuardLogStatement +org.apache.maven.DefaultProjectDependenciesResolver=MissingOverride +org.apache.maven.MavenArtifactTypeRegistry=MissingOverride +org.apache.maven.ReactorReader=UselessParentheses,MissingOverride,GuardLogStatement +org.apache.maven.RepositoryUtils=ForLoopVariableCount +org.apache.maven.api.ChildrenPointer=MissingOverride +org.apache.maven.api.DefaultExtensibleEnum=MissingOverride +org.apache.maven.api.DefaultPathScope=UseEnumCollections +org.apache.maven.api.DependenciesPointer=MissingOverride +org.apache.maven.api.DependencyScope=UnnecessaryFullyQualifiedName +org.apache.maven.api.ExtensibleEnums=AbstractClassWithoutAbstractMethod +org.apache.maven.api.JavaPathType=UnnecessaryModifier,UnnecessaryFullyQualifiedName +org.apache.maven.api.Language=ConstantsInInterface +org.apache.maven.api.MonotonicClock=UnnecessaryFullyQualifiedName +org.apache.maven.api.Packaging=MissingOverride +org.apache.maven.api.PhasePointer=MissingOverride +org.apache.maven.api.ProjectScope=ConstantsInInterface +org.apache.maven.api.Type=MissingOverride +org.apache.maven.api.Version=MissingOverride +org.apache.maven.api.VersionConstraint=MissingOverride +org.apache.maven.api.VersionRange=MissingOverride +org.apache.maven.api.cli.mvn.MavenOptions=MissingOverride +org.apache.maven.api.cli.mvnenc.EncryptOptions=MissingOverride +org.apache.maven.api.cli.mvnsh.ShellOptions=MissingOverride +org.apache.maven.api.model.InputLocation=MissingOverride +org.apache.maven.api.plugin.testing.Foo=UnnecessaryFullyQualifiedName +org.apache.maven.api.plugin.testing.MojoExtension=CollapsibleIfStatements,UseVarargs +org.apache.maven.api.plugin.testing.stubs.PluginStub=MissingOverride +org.apache.maven.api.plugin.testing.stubs.RepositorySystemSupplier=LooseCoupling +org.apache.maven.api.plugin.testing.stubs.SessionMock=TooManyStaticImports +org.apache.maven.api.plugin.testing.stubs.SessionStub=LooseCoupling +org.apache.maven.api.services.ArtifactCoordinatesFactoryRequest=UnnecessaryFullyQualifiedName +org.apache.maven.api.services.ArtifactFactoryRequest=UnnecessaryFullyQualifiedName +org.apache.maven.api.services.BaseRequest=MissingOverride +org.apache.maven.api.services.DefaultArtifactFactoryRequestArtifact=MissingOverride +org.apache.maven.api.services.DefaultDependencyCoordinatesFactoryRequest=MissingOverride +org.apache.maven.api.services.DependencyCoordinatesFactoryRequest=UnnecessaryFullyQualifiedName +org.apache.maven.api.services.MessageBuilder=UseVarargs +org.apache.maven.api.services.ModelBuilderResult=MissingOverride +org.apache.maven.api.services.xml.DefaultXmlReaderRequest=MissingOverride +org.apache.maven.api.spi.PropertyContributor=LooseCoupling +org.apache.maven.api.xml.Impl=UnusedAssignment,AvoidReassigningParameters +org.apache.maven.artifact.ArtifactStatus=MissingOverride +org.apache.maven.artifact.ArtifactUtils=UnnecessaryFullyQualifiedName +org.apache.maven.artifact.DefaultArtifact=UselessParentheses,AvoidReassigningParameters,LiteralsFirstInComparisons +org.apache.maven.artifact.InvalidArtifactRTException=MissingOverride +org.apache.maven.artifact.deployer.DefaultArtifactDeployer=EmptyControlStatement,MissingOverride +org.apache.maven.artifact.factory.DefaultArtifactFactory=MissingOverride +org.apache.maven.artifact.handler.manager.DefaultArtifactHandlerManager=CollapsibleIfStatements,LooseCoupling +org.apache.maven.artifact.handler.manager.LegacyArtifactHandlerManager=CollapsibleIfStatements +org.apache.maven.artifact.installer.DefaultArtifactInstaller=EmptyControlStatement,MissingOverride +org.apache.maven.artifact.manager.DefaultWagonManager=MissingOverride,AvoidReassigningLoopVariables,GuardLogStatement,AvoidReassigningParameters +org.apache.maven.artifact.metadata.AbstractArtifactMetadata=UnnecessaryFullyQualifiedName +org.apache.maven.artifact.metadata.ArtifactMetadataSource=MissingOverride +org.apache.maven.artifact.repository.ArtifactMetadataAdapter=MissingOverride +org.apache.maven.artifact.repository.ArtifactRepositoryAdapter=MissingOverride +org.apache.maven.artifact.repository.ArtifactRepositoryPolicy=UnnecessaryFullyQualifiedName,AvoidReassigningParameters +org.apache.maven.artifact.repository.DefaultArtifactRepository=UnusedFormalParameter,AvoidReassigningParameters,MissingOverride +org.apache.maven.artifact.repository.DefaultArtifactRepositoryFactory=MissingOverride,PreserveStackTrace +org.apache.maven.artifact.repository.DefaultRepositoryRequest=MissingOverride +org.apache.maven.artifact.repository.LegacyLocalRepositoryManager=AvoidReassigningParameters,MissingOverride +org.apache.maven.artifact.repository.MavenArtifactRepository=MissingOverride,LiteralsFirstInComparisons +org.apache.maven.artifact.repository.layout.DefaultRepositoryLayout=MissingOverride +org.apache.maven.artifact.repository.layout.FlatRepositoryLayout=MissingOverride +org.apache.maven.artifact.repository.metadata.AbstractRepositoryMetadata=UnnecessaryFullyQualifiedName,MissingOverride +org.apache.maven.artifact.repository.metadata.ArtifactRepositoryMetadata=MissingOverride +org.apache.maven.artifact.repository.metadata.DefaultRepositoryMetadataManager=CollapsibleIfStatements,MissingOverride,GuardLogStatement +org.apache.maven.artifact.repository.metadata.GroupRepositoryMetadata=MissingOverride +org.apache.maven.artifact.repository.metadata.MetadataBridge=MissingOverride +org.apache.maven.artifact.repository.metadata.SnapshotArtifactRepositoryMetadata=MissingOverride +org.apache.maven.artifact.repository.metadata.io.DefaultMetadataReader=MissingOverride +org.apache.maven.artifact.repository.metadata.io.xpp3.MetadataXpp3Writer=UnnecessaryFullyQualifiedName +org.apache.maven.artifact.resolver.AbstractArtifactResolutionException=ForLoopCanBeForeach +org.apache.maven.artifact.resolver.ArtifactResolutionRequest=MissingOverride +org.apache.maven.artifact.resolver.ArtifactResolutionResult=MissingOverride +org.apache.maven.artifact.resolver.CyclicDependencyException=MissingOverride +org.apache.maven.artifact.resolver.DaemonThreadCreator=AvoidThreadGroup,MissingOverride +org.apache.maven.artifact.resolver.DebugResolutionListener=MissingOverride,GuardLogStatement +org.apache.maven.artifact.resolver.DefaultArtifactResolver=MissingOverride,PreserveStackTrace,GuardLogStatement +org.apache.maven.artifact.resolver.DefaultResolutionErrorHandler=MissingOverride +org.apache.maven.artifact.resolver.ResolveTask=MissingOverride +org.apache.maven.artifact.resolver.WarningResolutionListener=MissingOverride +org.apache.maven.artifact.resolver.filter.AbstractScopeArtifactFilter=MissingOverride +org.apache.maven.artifact.resolver.filter.AndArtifactFilter=MissingOverride +org.apache.maven.artifact.resolver.filter.ExcludesArtifactFilter=MissingOverride +org.apache.maven.artifact.resolver.filter.ExclusionArtifactFilter=UnusedPrivateField +org.apache.maven.artifact.resolver.filter.ExclusionSetFilter=UseVarargs,MissingOverride +org.apache.maven.artifact.resolver.filter.IncludesArtifactFilter=MissingOverride +org.apache.maven.artifact.resolver.filter.InversionArtifactFilter=MissingOverride +org.apache.maven.artifact.resolver.filter.OrArtifactFilter=MissingOverride +org.apache.maven.artifact.resolver.filter.TypeArtifactFilter=UnusedAssignment,MissingOverride +org.apache.maven.artifact.versioning.BigIntegerItem=MissingOverride +org.apache.maven.artifact.versioning.CombinationItem=UnusedAssignment +org.apache.maven.artifact.versioning.ComparableVersion=UselessParentheses,LooseCoupling,AvoidReassigningParameters,AvoidReassigningLoopVariables,SystemPrintln +org.apache.maven.artifact.versioning.DefaultArtifactVersion=MissingOverride +org.apache.maven.artifact.versioning.ListItem=UselessParentheses,LooseCoupling +org.apache.maven.artifact.versioning.ManagedVersionMap=MissingOverride +org.apache.maven.artifact.versioning.Restriction=MissingOverride +org.apache.maven.artifact.versioning.StringItem=AvoidReassigningParameters,LiteralsFirstInComparisons,MissingOverride +org.apache.maven.artifact.versioning.VersionRange=CollapsibleIfStatements,UseCollectionIsEmpty,MissingOverride +org.apache.maven.bridge.MavenRepositorySystem=UnnecessaryFullyQualifiedName,AvoidUsingHardCodedIP,UselessParentheses,AvoidReassigningParameters,LiteralsFirstInComparisons +org.apache.maven.building.DefaultProblem=MissingOverride +org.apache.maven.classrealm.ArtifactClassRealmConstituent=MissingOverride +org.apache.maven.classrealm.DefaultClassRealmManager=MissingOverride,AvoidReassigningParameters,GuardLogStatement +org.apache.maven.classrealm.DefaultClassRealmRequest=MissingOverride +org.apache.maven.cli.CLIManager=UseVarargs +org.apache.maven.cli.CLIReportingUtils=UselessParentheses,SystemPrintln,GuardLogStatement +org.apache.maven.cli.CleanArgument=UseVarargs,SystemPrintln +org.apache.maven.cli.CliRequest=ArrayIsStoredDirectly,MethodReturnsInternalArray +org.apache.maven.cli.ExtensionInterpolator=MissingOverride +org.apache.maven.cli.MavenCli=UnnecessaryFullyQualifiedName,UselessParentheses,SystemPrintln,LiteralsFirstInComparisons,GuardLogStatement,AvoidPrintStackTrace,AvoidReassigningParameters,PreserveStackTrace +org.apache.maven.cli.configuration.SettingsXmlConfigurationProcessor=UnusedFormalParameter,GuardLogStatement +org.apache.maven.cli.event.DefaultEventSpyContext=MissingOverride +org.apache.maven.cli.event.ExecutionEventLogger=GuardLogStatement +org.apache.maven.cli.internal.BootstrapCoreExtensionManager=GuardLogStatement +org.apache.maven.cli.logging.Slf4jStdoutLogger=MissingOverride +org.apache.maven.cli.props.MavenProperties=CollapsibleIfStatements,MissingOverride,AvoidReassigningParameters,LooseCoupling +org.apache.maven.cli.props.MavenPropertiesLoader=UselessParentheses,LooseCoupling +org.apache.maven.cli.transfer.AbstractMavenTransferListener=UselessParentheses +org.apache.maven.cli.transfer.ConsoleMavenTransferListener=UnusedFormalParameter,AvoidReassigningParameters +org.apache.maven.cli.transfer.FileSizeFormat=AvoidReassigningParameters +org.apache.maven.cli.transfer.SimplexTransferListener=LooseCoupling +org.apache.maven.cli.transfer.Slf4jMavenTransferListener=UselessParentheses,GuardLogStatement +org.apache.maven.cling.ClingSupport=UseTryWithResources,GuardLogStatement,UseVarargs +org.apache.maven.cling.event.ExecutionEventLogger=GuardLogStatement +org.apache.maven.cling.executor.embedded.Context=UnusedPrivateField +org.apache.maven.cling.executor.embedded.EmbeddedMavenExecutor=LooseCoupling,UnnecessaryVarargsArrayCreation,UseTryWithResources +org.apache.maven.cling.executor.forked.ForkedMavenExecutor=LooseCoupling +org.apache.maven.cling.executor.internal.HelperImpl=LooseCoupling,UseEnumCollections +org.apache.maven.cling.executor.internal.ToolboxTool=SystemPrintln +org.apache.maven.cling.extensions.BootstrapCoreExtensionManager=GuardLogStatement +org.apache.maven.cling.extensions.ExtensionInterpolator=MissingOverride +org.apache.maven.cling.invoker.BaseParser=TooManyStaticImports,GuardLogStatement,LiteralsFirstInComparisons,LooseCoupling +org.apache.maven.cling.invoker.CLIManager=LooseCoupling,UseVarargs +org.apache.maven.cling.invoker.CleanArgument=UseVarargs,SystemPrintln +org.apache.maven.cling.invoker.CliUtils=AvoidReassigningParameters,LooseCoupling +org.apache.maven.cling.invoker.LayeredOptions=LooseCoupling +org.apache.maven.cling.invoker.LookupInvoker=SimplifiedTernary,AvoidReassigningParameters,GuardLogStatement,LooseCoupling,PreserveStackTrace +org.apache.maven.cling.invoker.PlexusContainerCapsuleFactory=LooseCoupling,GuardLogStatement +org.apache.maven.cling.invoker.PrecedenceCoreExtensionSelector=GuardLogStatement,LooseCoupling +org.apache.maven.cling.invoker.cisupport.CIDetectorHelper=LooseCoupling +org.apache.maven.cling.invoker.mvn.CommonsCliMavenOptions=UseVarargs +org.apache.maven.cling.invoker.mvn.LayeredMavenOptions=LooseCoupling +org.apache.maven.cling.invoker.mvn.MavenInvoker=GuardLogStatement,AvoidReassigningParameters +org.apache.maven.cling.invoker.mvn.MavenInvokerRequest=MissingOverride +org.apache.maven.cling.invoker.mvn.MavenParser=LooseCoupling,PreserveStackTrace +org.apache.maven.cling.invoker.mvn.resident.ResidentMavenInvoker=LooseCoupling +org.apache.maven.cling.invoker.mvnenc.CommonsCliEncryptOptions=UnnecessaryFullyQualifiedName,UseVarargs +org.apache.maven.cling.invoker.mvnenc.EncryptInvoker=GuardLogStatement +org.apache.maven.cling.invoker.mvnenc.EncryptInvokerRequest=MissingOverride +org.apache.maven.cling.invoker.mvnenc.goals.ConfiguredGoalSupport=GuardLogStatement +org.apache.maven.cling.invoker.mvnenc.goals.Init=GuardLogStatement +org.apache.maven.cling.invoker.mvnsh.CommonsCliShellOptions=UnnecessaryFullyQualifiedName,UseVarargs +org.apache.maven.cling.invoker.mvnsh.ShellCommandRegistryHolder=LooseCoupling +org.apache.maven.cling.invoker.mvnsh.ShellInvokerRequest=MissingOverride +org.apache.maven.cling.invoker.mvnsh.builtin.BuiltinShellCommandRegistry=UnusedFormalParameter,GuardLogStatement +org.apache.maven.cling.invoker.mvnsh.builtin.BuiltinShellCommandRegistryFactory=MissingOverride +org.apache.maven.cling.logging.Slf4jLoggerManager=UselessParentheses +org.apache.maven.cling.logging.impl.MavenSimpleConfiguration=GuardLogStatement +org.apache.maven.cling.logging.impl.UnsupportedSlf4jBindingConfiguration=UnusedFormalParameter +org.apache.maven.cling.props.MavenProperties=CollapsibleIfStatements,MissingOverride,AvoidReassigningParameters,LooseCoupling +org.apache.maven.cling.props.MavenPropertiesLoader=UselessParentheses,LooseCoupling +org.apache.maven.cling.transfer.AbstractMavenTransferListener=UselessParentheses +org.apache.maven.cling.transfer.ConsoleMavenTransferListener=UnusedFormalParameter,AvoidStringBufferField,AvoidReassigningParameters +org.apache.maven.cling.transfer.FileSizeFormat=AvoidReassigningParameters +org.apache.maven.cling.transfer.SimplexTransferListener=LooseCoupling +org.apache.maven.cling.transfer.Slf4jMavenTransferListener=UselessParentheses,GuardLogStatement +org.apache.maven.cling.utils.CLIReportingUtils=UnusedPrivateField,UselessParentheses,SystemPrintln,GuardLogStatement +org.apache.maven.configuration.BasedirBeanConfigurationPathTranslator=EmptyControlStatement,MissingOverride +org.apache.maven.configuration.DefaultBeanConfigurationRequest=MissingOverride +org.apache.maven.configuration.internal.BeanExpressionEvaluator=MissingOverride +org.apache.maven.configuration.internal.DefaultBeanConfigurator=MissingOverride +org.apache.maven.configuration.internal.EnhancedConfigurationConverter=MissingOverride +org.apache.maven.di.Key=AbstractClassWithoutAbstractMethod +org.apache.maven.di.impl.Binding=UseVarargs,ArrayIsStoredDirectly,UnnecessaryFullyQualifiedName +org.apache.maven.di.impl.BindingToConstructor=ArrayIsStoredDirectly +org.apache.maven.di.impl.InjectorImpl=LooseCoupling +org.apache.maven.di.impl.ParameterizedTypeImpl=UseVarargs,ArrayIsStoredDirectly,MethodReturnsInternalArray +org.apache.maven.di.impl.ReflectionUtils=AvoidReassigningParameters,UnnecessaryFullyQualifiedName +org.apache.maven.di.impl.SingletonScope=UnnecessaryFullyQualifiedName +org.apache.maven.di.impl.Types=JumbledIncrementer,UnnecessaryFullyQualifiedName,UseVarargs,AvoidReassigningLoopVariables,OneDeclarationPerLine,AvoidReassigningParameters +org.apache.maven.di.impl.WildcardTypeImpl=UseVarargs,ArrayIsStoredDirectly,MethodReturnsInternalArray +org.apache.maven.eventspy.AbstractEventSpy=MissingOverride +org.apache.maven.exception.DefaultExceptionHandler=UselessParentheses,AvoidReassigningParameters +org.apache.maven.execution.AbstractExecutionListener=MissingOverride +org.apache.maven.execution.BuildSummary=AbstractClassWithoutAbstractMethod +org.apache.maven.execution.DefaultMavenExecutionRequestPopulator=AvoidReassigningLoopVariables +org.apache.maven.execution.DefaultMavenExecutionResult=MissingOverride +org.apache.maven.execution.DefaultRuntimeInformation=MissingOverride +org.apache.maven.execution.MavenSession=UnusedFormalParameter,UnnecessaryVarargsArrayCreation +org.apache.maven.execution.scope.internal.MojoExecutionScope=MissingOverride,LooseCoupling +org.apache.maven.extension.internal.CoreExportsProvider=MissingOverride +org.apache.maven.graph.DefaultGraphBuilder=UselessParentheses,GuardLogStatement +org.apache.maven.graph.DefaultProjectDependencyGraph=MissingOverride +org.apache.maven.impl.AetherDependencyWrapper=AbstractClassWithoutAbstractMethod +org.apache.maven.impl.DefaultChecksumAlgorithmService=LooseCoupling +org.apache.maven.impl.DefaultDependencyResolverResult=AvoidReassigningLoopVariables +org.apache.maven.impl.DefaultMessageBuilder=AvoidStringBufferField +org.apache.maven.impl.DefaultNode=UnnecessaryFullyQualifiedName,UselessParentheses +org.apache.maven.impl.DefaultPluginConfigurationExpander=AvoidReassigningParameters +org.apache.maven.impl.DefaultPluginXmlFactory=UnusedLocalVariable +org.apache.maven.impl.DefaultRepositoryFactory=UnnecessaryFullyQualifiedName +org.apache.maven.impl.DefaultSettingsBuilder=UnusedFormalParameter +org.apache.maven.impl.DefaultSourceRoot=AvoidReassigningParameters +org.apache.maven.impl.DefaultToolchainManager=GuardLogStatement,LooseCoupling +org.apache.maven.impl.DefaultToolchainsBuilder=UnusedFormalParameter +org.apache.maven.impl.DefaultTransportProvider=UnnecessaryFullyQualifiedName +org.apache.maven.impl.ExcludeFromFailureFile=SystemPrintln,AvoidPrintStackTrace +org.apache.maven.impl.InternalSession=UnnecessaryFullyQualifiedName +org.apache.maven.impl.PathModularization=PreserveStackTrace +org.apache.maven.impl.PathSelector=AvoidReassigningParameters,UseVarargs,NonExhaustiveSwitch,AvoidReassigningLoopVariables +org.apache.maven.impl.PropertiesAsMap=UnnecessaryFullyQualifiedName +org.apache.maven.impl.RequestTraceHelper=AvoidReassigningParameters +org.apache.maven.impl.SettingsUtilsV4=UnnecessaryFullyQualifiedName +org.apache.maven.impl.cache.DefaultRequestCache=MissingOverride +org.apache.maven.impl.cache.DefaultRequestCacheFactory=MissingOverride +org.apache.maven.impl.cache.SoftIdentityMap=LooseCoupling +org.apache.maven.impl.di.MojoExecutionScope=LooseCoupling,MissingOverride +org.apache.maven.impl.di.SessionScope=UseVarargs +org.apache.maven.impl.model.DefaultInheritanceAssembler=UselessParentheses,AvoidReassigningLoopVariables +org.apache.maven.impl.model.DefaultInterpolator=AvoidReassigningParameters +org.apache.maven.impl.model.DefaultLifecycleBindingsInjector=MissingOverride +org.apache.maven.impl.model.DefaultModelBuilder=MissingOverride,AvoidReassigningLoopVariables,LiteralsFirstInComparisons,UnnecessaryFullyQualifiedName +org.apache.maven.impl.model.DefaultModelBuilderResult=MissingOverride +org.apache.maven.impl.model.DefaultModelInterpolator=AvoidReassigningParameters,LiteralsFirstInComparisons,EmptyControlStatement +org.apache.maven.impl.model.DefaultModelNormalizer=AvoidReassigningLoopVariables +org.apache.maven.impl.model.DefaultModelPathTranslator=AvoidReassigningParameters +org.apache.maven.impl.model.DefaultModelProblem=MissingOverride +org.apache.maven.impl.model.DefaultModelProcessor=AvoidReassigningParameters +org.apache.maven.impl.model.DefaultModelValidator=LooseCoupling,ForLoopVariableCount,UseVarargs,AvoidReassigningParameters,UnnecessaryFullyQualifiedName +org.apache.maven.impl.model.DefaultPathTranslator=AvoidReassigningParameters +org.apache.maven.impl.model.DefaultProfileActivationContext=OneDeclarationPerLine +org.apache.maven.impl.model.DefaultProfileInjector=AvoidReassigningParameters +org.apache.maven.impl.model.Graph=LooseCoupling +org.apache.maven.impl.model.InheritanceModelMerger=AvoidReassigningLoopVariables +org.apache.maven.impl.model.InliningTransformer=MissingOverride +org.apache.maven.impl.model.LifecycleBindingsMerger=AvoidReassigningLoopVariables +org.apache.maven.impl.model.ManagementModelMerger=AvoidReassigningLoopVariables +org.apache.maven.impl.model.MavenBuildTimestamp=AvoidReassigningParameters +org.apache.maven.impl.model.MavenModelMerger=ForLoopVariableCount,OneDeclarationPerLine,AvoidReassigningLoopVariables +org.apache.maven.impl.model.ModelBuilderSessionState=PreserveStackTrace,AvoidReassigningParameters,GuardLogStatement,MissingOverride,CollapsibleIfStatements,AvoidReassigningLoopVariables +org.apache.maven.impl.model.ProfileModelMerger=AvoidReassigningLoopVariables +org.apache.maven.impl.model.Record=UseEnumCollections +org.apache.maven.impl.model.profile.ConditionParser=AvoidReassigningLoopVariables,LiteralsFirstInComparisons,PreserveStackTrace +org.apache.maven.impl.model.profile.JdkVersionProfileActivator=AvoidReassigningParameters +org.apache.maven.impl.model.reflection.ClassMap=ReplaceHashtableWithMap,AvoidReassigningLoopVariables,AvoidReassigningParameters +org.apache.maven.impl.model.reflection.MethodMap=ReplaceHashtableWithMap,LooseCoupling,UseVarargs +org.apache.maven.impl.model.rootlocator.DefaultRootLocator=MissingOverride,GuardLogStatement +org.apache.maven.impl.model.rootlocator.PomXmlRootDetector=LiteralsFirstInComparisons +org.apache.maven.impl.resolver.DefaultArtifactDescriptorReader=LooseCoupling,AvoidReassigningLoopVariables,PreserveStackTrace,GuardLogStatement +org.apache.maven.impl.resolver.DefaultModelResolver=MissingOverride +org.apache.maven.impl.resolver.LocalSnapshotMetadataGenerator=UnusedFormalParameter +org.apache.maven.impl.resolver.MavenMetadata=MissingOverride +org.apache.maven.impl.resolver.PluginsMetadata=LooseCoupling +org.apache.maven.impl.resolver.PluginsMetadataGenerator=LooseCoupling,GuardLogStatement +org.apache.maven.impl.resolver.RemoteSnapshotMetadataGenerator=AvoidReassigningParameters +org.apache.maven.impl.resolver.relocation.DistributionManagementArtifactRelocationSource=GuardLogStatement +org.apache.maven.impl.resolver.relocation.UserPropertiesArtifactRelocationSource=GuardLogStatement +org.apache.maven.impl.resolver.scopes.Maven3ScopeManagerConfiguration=LooseCoupling,TooManyStaticImports,UnnecessaryFullyQualifiedName +org.apache.maven.impl.resolver.scopes.Maven4ScopeManagerConfiguration=LooseCoupling,TooManyStaticImports,UnnecessaryFullyQualifiedName +org.apache.maven.impl.resolver.type.DefaultType=MissingOverride +org.apache.maven.impl.standalone.DefaultSession=LooseCoupling +org.apache.maven.internal.aether.DefaultRepositorySystemSessionFactory=EmptyControlStatement,MissingOverride,GuardLogStatement,LooseCoupling +org.apache.maven.internal.aether.LoggingRepositoryListener=GuardLogStatement +org.apache.maven.internal.aether.ReverseTreeRepositoryListener=LooseCoupling,AvoidReassigningParameters +org.apache.maven.internal.impl.CleanLifecycle=UnnecessaryFullyQualifiedName +org.apache.maven.internal.impl.DefaultLifecycle=UnnecessaryFullyQualifiedName +org.apache.maven.internal.impl.DefaultLifecycleRegistry=UnnecessaryFullyQualifiedName,TooManyStaticImports,MissingOverride +org.apache.maven.internal.impl.DefaultLog=MissingOverride,GuardLogStatement +org.apache.maven.internal.impl.DefaultPackagingRegistry=AvoidReassigningParameters,OneDeclarationPerLine,GuardLogStatement +org.apache.maven.internal.impl.DefaultProject=LooseCoupling +org.apache.maven.internal.impl.DefaultProjectManager=LooseCoupling,AvoidReassigningParameters +org.apache.maven.internal.impl.DefaultSession=MissingOverride,LooseCoupling +org.apache.maven.internal.impl.DefaultTypeRegistry=CollapsibleIfStatements,LooseCoupling +org.apache.maven.internal.impl.Graph=LooseCoupling +org.apache.maven.internal.impl.SiteLifecycle=UnnecessaryFullyQualifiedName +org.apache.maven.internal.transformation.impl.DefaultConsumerPomArtifactTransformer=UnusedPrivateMethod,MissingOverride,LooseCoupling,AvoidReassigningParameters +org.apache.maven.internal.transformation.impl.DefaultConsumerPomBuilder=UnusedFormalParameter,AvoidReassigningParameters,GuardLogStatement +org.apache.maven.internal.xml.DefaultXmlService=MissingOverride,UseVarargs,UnusedPrivateMethod +org.apache.maven.internal.xml.XmlNodeImpl=MissingOverride,UnusedAssignment,AvoidReassigningParameters +org.apache.maven.internal.xml.XmlPlexusConfiguration=ForLoopVariableCount +org.apache.maven.jline.DefaultPrompter=UselessParentheses,AvoidReassigningParameters +org.apache.maven.jline.MavenStyleResolver=AvoidReassigningParameters +org.apache.maven.jline.MessageUtils=UnnecessaryFullyQualifiedName +org.apache.maven.lifecycle.DefaultLifecycleExecutor=MissingOverride +org.apache.maven.lifecycle.DefaultLifecycles=UnusedFormalParameter +org.apache.maven.lifecycle.LifecycleExecutionException=UnusedFormalParameter +org.apache.maven.lifecycle.MavenExecutionPlan=LooseCoupling,MissingOverride +org.apache.maven.lifecycle.internal.DefaultLifecycleExecutionPlanCalculator=UselessParentheses +org.apache.maven.lifecycle.internal.DefaultLifecycleMappingDelegate=AvoidReassigningParameters +org.apache.maven.lifecycle.internal.DefaultLifecyclePluginAnalyzer=GuardLogStatement +org.apache.maven.lifecycle.internal.DefaultLifecycleStarter=UnusedAssignment,GuardLogStatement +org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator=UselessParentheses,AvoidReassigningLoopVariables +org.apache.maven.lifecycle.internal.DefaultMojoExecutionConfigurator=GuardLogStatement +org.apache.maven.lifecycle.internal.DefaultProjectArtifactFactory=AvoidReassigningParameters +org.apache.maven.lifecycle.internal.LifecycleDebugLogger=GuardLogStatement +org.apache.maven.lifecycle.internal.LifecycleDependencyResolver=AvoidReassigningParameters +org.apache.maven.lifecycle.internal.LifecycleModuleBuilder=PreserveStackTrace +org.apache.maven.lifecycle.internal.MojoDescriptorCreator=GuardLogStatement +org.apache.maven.lifecycle.internal.MojoExecutor=UnusedLocalVariable +org.apache.maven.lifecycle.internal.ReactorDependencyFilter=MissingOverride +org.apache.maven.lifecycle.internal.Task=AbstractClassWithoutAbstractMethod +org.apache.maven.lifecycle.internal.builder.BuilderCommon=EmptyControlStatement,GuardLogStatement +org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder=GuardLogStatement +org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder=MissingOverride +org.apache.maven.lifecycle.internal.concurrent.BuildContext=UnusedLocalVariable,CollapsibleIfStatements,EmptyControlStatement,GuardLogStatement +org.apache.maven.lifecycle.internal.concurrent.BuildPlanExecutor=TooManyStaticImports,UselessParentheses +org.apache.maven.lifecycle.internal.concurrent.BuildPlanLogger=LooseCoupling +org.apache.maven.lifecycle.internal.concurrent.ConcurrentLifecycleStarter=UselessParentheses,MissingOverride,GuardLogStatement,AvoidReassigningLoopVariables +org.apache.maven.lifecycle.providers.AbstractLifecycleProvider=UseVarargs,LooseCoupling +org.apache.maven.lifecycle.providers.packaging.AbstractLifecycleMappingProvider=UseVarargs,LooseCoupling +org.apache.maven.logging.LoggingExecutionListener=UselessParentheses +org.apache.maven.logging.ProjectBuildLogAppender=AvoidReassigningParameters +org.apache.maven.model.building.DefaultModelBuilder=AvoidReassigningLoopVariables,AvoidReassigningParameters,PreserveStackTrace,LooseCoupling,LiteralsFirstInComparisons +org.apache.maven.model.building.FileModelSource=AvoidReassigningParameters +org.apache.maven.model.building.Graph=LooseCoupling +org.apache.maven.model.building.ModelBuildingException=AvoidReassigningParameters +org.apache.maven.model.building.ModelProcessor=ConstantsInInterface +org.apache.maven.model.inheritance.DefaultInheritanceAssembler=AvoidReassigningLoopVariables +org.apache.maven.model.interpolation.InterpolateObjectAction=LooseCoupling +org.apache.maven.model.interpolation.ListField=ForLoopVariableCount +org.apache.maven.model.interpolation.MavenBuildTimestamp=AvoidReassigningParameters +org.apache.maven.model.interpolation.ModelVisitor=OneDeclarationPerLine,ForLoopVariableCount +org.apache.maven.model.interpolation.ObjectBasedValueSource=MissingOverride +org.apache.maven.model.interpolation.PathTranslatingPostProcessor=AvoidReassigningParameters +org.apache.maven.model.interpolation.PrefixedObjectValueSource=MissingOverride +org.apache.maven.model.interpolation.reflection.ClassMap=ReplaceHashtableWithMap,AvoidReassigningLoopVariables,AvoidReassigningParameters +org.apache.maven.model.interpolation.reflection.MethodMap=ReplaceHashtableWithMap,LooseCoupling,UseVarargs +org.apache.maven.model.io.xpp3.MavenXpp3WriterEx=MissingOverride +org.apache.maven.model.merge.MavenModelMerger=ForLoopVariableCount,OneDeclarationPerLine +org.apache.maven.model.merge.MergingList=LooseCoupling +org.apache.maven.model.merge.ModelMerger=LooseCoupling +org.apache.maven.model.path.DefaultPathTranslator=AvoidReassigningParameters +org.apache.maven.model.plugin.DefaultLifecycleBindingsInjector=MissingOverride +org.apache.maven.model.profile.activation.JdkVersionProfileActivator=AvoidReassigningParameters +org.apache.maven.model.root.DefaultRootLocator=MissingOverride,LiteralsFirstInComparisons +org.apache.maven.model.validation.DefaultModelValidator=UnusedFormalParameter,LooseCoupling,ForLoopVariableCount,AvoidReassigningParameters +org.apache.maven.monitor.logging.DefaultLog=GuardLogStatement,MissingOverride +org.apache.maven.plugin.CompoundMojoExecutionListener=MissingOverride +org.apache.maven.plugin.CycleDetectedInPluginGraphException=UnusedFormalParameter +org.apache.maven.plugin.DebugConfigurationListener=MissingOverride +org.apache.maven.plugin.DefaultExtensionRealmCache=MissingOverride +org.apache.maven.plugin.DefaultPluginArtifactsCache=MissingOverride +org.apache.maven.plugin.DefaultPluginDescriptorCache=MissingOverride +org.apache.maven.plugin.DefaultPluginRealmCache=MissingOverride,PreserveStackTrace +org.apache.maven.plugin.MavenPluginPrerequisitesChecker=MissingOverride +org.apache.maven.plugin.PluginConfigurationException=UnusedPrivateField +org.apache.maven.plugin.PluginParameterException=UselessParentheses,ForLoopCanBeForeach +org.apache.maven.plugin.PluginParameterExpressionEvaluator=UselessParentheses,EmptyControlStatement,LiteralsFirstInComparisons,AvoidReassigningParameters +org.apache.maven.plugin.PluginParameterExpressionEvaluatorV4=UselessParentheses,CollapsibleIfStatements,EmptyControlStatement,AvoidReassigningParameters +org.apache.maven.plugin.descriptor.MojoDescriptor=LooseCoupling,MissingOverride +org.apache.maven.plugin.descriptor.Parameter=MissingOverride +org.apache.maven.plugin.descriptor.PluginDescriptor=MissingOverride +org.apache.maven.plugin.internal.DefaultLegacySupport=UnnecessaryFullyQualifiedName,MissingOverride +org.apache.maven.plugin.internal.DefaultMavenPluginManager=MissingOverride,PreserveStackTrace,GuardLogStatement +org.apache.maven.plugin.internal.DefaultPluginDependenciesResolver=MissingOverride,AvoidReassigningParameters +org.apache.maven.plugin.internal.DefaultPluginManager=MissingOverride,PreserveStackTrace +org.apache.maven.plugin.internal.DefaultPluginValidationManager=GuardLogStatement,LooseCoupling +org.apache.maven.plugin.internal.DeprecatedCoreExpressionValidator=LooseCoupling +org.apache.maven.plugin.internal.MavenPluginMavenPrerequisiteChecker=UnusedAssignment,GuardLogStatement +org.apache.maven.plugin.internal.MojoLogWrapper=MissingOverride +org.apache.maven.plugin.internal.PlexusContainerDefaultDependenciesValidator=MissingOverride +org.apache.maven.plugin.internal.PluginValidationIssues=LooseCoupling,UseEnumCollections +org.apache.maven.plugin.internal.ValidatingConfigurationListener=MissingOverride +org.apache.maven.plugin.logging.SystemStreamLog=MissingOverride,SystemPrintln +org.apache.maven.plugin.prefix.DefaultPluginPrefixRequest=MissingOverride +org.apache.maven.plugin.prefix.internal.DefaultPluginPrefixResolver=UselessParentheses,MissingOverride,GuardLogStatement +org.apache.maven.plugin.prefix.internal.DefaultPluginPrefixResult=MissingOverride +org.apache.maven.plugin.version.DefaultPluginVersionRequest=MissingOverride +org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver=GuardLogStatement,LooseCoupling +org.apache.maven.plugin.version.internal.DefaultPluginVersionResult=MissingOverride +org.apache.maven.profiles.DefaultProfileManager=MissingOverride,GuardLogStatement +org.apache.maven.profiles.activation.DetectedProfileActivator=MissingOverride +org.apache.maven.profiles.activation.FileProfileActivator=MissingOverride,GuardLogStatement +org.apache.maven.profiles.activation.JdkPrefixProfileActivator=MissingOverride,PreserveStackTrace +org.apache.maven.profiles.activation.OperatingSystemProfileActivator=MissingOverride +org.apache.maven.profiles.activation.SystemPropertyProfileActivator=MissingOverride +org.apache.maven.project.BuildSession=UselessParentheses,LooseCoupling,GuardLogStatement +org.apache.maven.project.DefaultDependencyResolutionRequest=MissingOverride +org.apache.maven.project.DefaultDependencyResolutionResult=MissingOverride +org.apache.maven.project.DefaultMavenProjectBuilder=MissingOverride +org.apache.maven.project.DefaultMavenProjectHelper=MissingOverride +org.apache.maven.project.DefaultProjectBuilder=UnusedFormalParameter +org.apache.maven.project.DefaultProjectBuilderConfiguration=MissingOverride +org.apache.maven.project.DefaultProjectBuildingHelper=MissingOverride +org.apache.maven.project.DefaultProjectBuildingRequest=MissingOverride +org.apache.maven.project.DefaultProjectBuildingResult=MissingOverride +org.apache.maven.project.DefaultProjectDependenciesResolver=MissingOverride,GuardLogStatement +org.apache.maven.project.DefaultProjectRealmCache=MissingOverride +org.apache.maven.project.Graph=LooseCoupling +org.apache.maven.project.MavenProject=UselessParentheses,UnusedFormalParameter,CollapsibleIfStatements,AvoidReassigningParameters +org.apache.maven.project.ProjectModelResolver=MissingOverride +org.apache.maven.project.ProjectSorter=UselessParentheses +org.apache.maven.project.artifact.ActiveProjectArtifact=MissingOverride +org.apache.maven.project.artifact.AttachedArtifact=MissingOverride +org.apache.maven.project.artifact.DefaultMavenMetadataCache=ForLoopVariableCount,MissingOverride +org.apache.maven.project.artifact.DefaultProjectArtifactsCache=LooseCoupling +org.apache.maven.project.artifact.MavenMetadataSource=LiteralsFirstInComparisons,AvoidReassigningParameters,PreserveStackTrace,GuardLogStatement +org.apache.maven.project.artifact.PluginArtifact=MissingOverride +org.apache.maven.project.artifact.ProjectArtifact=MissingOverride +org.apache.maven.project.artifact.ProjectArtifactMetadata=MissingOverride +org.apache.maven.project.collector.DefaultProjectsSelector=UselessParentheses,GuardLogStatement +org.apache.maven.project.collector.MultiModuleCollectionStrategy=GuardLogStatement +org.apache.maven.project.interpolation.AbstractStringBasedModelInterpolator=MissingOverride,AvoidReassigningParameters,GuardLogStatement +org.apache.maven.project.interpolation.BuildTimestampValueSource=MissingOverride +org.apache.maven.project.interpolation.InterpolateObjectAction=LooseCoupling,MissingOverride,GuardLogStatement +org.apache.maven.project.interpolation.PathTranslatingPostProcessor=MissingOverride,AvoidReassigningParameters +org.apache.maven.project.interpolation.RegexBasedModelInterpolator=UnusedFormalParameter,MissingOverride +org.apache.maven.project.interpolation.StringSearchModelInterpolator=MissingOverride +org.apache.maven.project.path.DefaultPathTranslator=CollapsibleIfStatements,MissingOverride,AvoidReassigningParameters +org.apache.maven.project.validation.DefaultModelValidator=MissingOverride +org.apache.maven.project.validation.ModelValidationResult=MissingOverride,UseCollectionIsEmpty +org.apache.maven.project.validation.SimpleModelProblemCollector=MissingOverride +org.apache.maven.repository.ArtifactTransferEvent=MethodReturnsInternalArray,ArrayIsStoredDirectly,MissingOverride +org.apache.maven.repository.DefaultMirrorSelector=AvoidUsingHardCodedIP,UselessParentheses,MissingOverride,AvoidReassigningLoopVariables,LiteralsFirstInComparisons +org.apache.maven.repository.DelegatingLocalArtifactRepository=AvoidReassigningParameters,MissingOverride +org.apache.maven.repository.LocalArtifactRepository=MissingOverride +org.apache.maven.repository.MetadataResolutionRequest=MissingOverride +org.apache.maven.repository.MetadataResolutionResult=MissingOverride +org.apache.maven.repository.internal.DefaultArtifactDescriptorReader=LooseCoupling,AvoidReassigningLoopVariables,PreserveStackTrace,GuardLogStatement +org.apache.maven.repository.internal.DefaultModelResolver=UnnecessaryFullyQualifiedName +org.apache.maven.repository.internal.LocalSnapshotMetadataGenerator=UnusedFormalParameter +org.apache.maven.repository.internal.MavenMetadata=MissingOverride +org.apache.maven.repository.internal.PluginsMetadata=LooseCoupling +org.apache.maven.repository.internal.PluginsMetadataGenerator=LooseCoupling,GuardLogStatement +org.apache.maven.repository.internal.RemoteSnapshotMetadataGenerator=AvoidReassigningParameters +org.apache.maven.repository.internal.RequestTraceHelper=AvoidReassigningParameters +org.apache.maven.repository.internal.relocation.DistributionManagementArtifactRelocationSource=GuardLogStatement +org.apache.maven.repository.internal.relocation.UserPropertiesArtifactRelocationSource=GuardLogStatement +org.apache.maven.repository.internal.scopes.Maven3ScopeManagerConfiguration=LooseCoupling +org.apache.maven.repository.internal.scopes.Maven4ScopeManagerConfiguration=LooseCoupling +org.apache.maven.repository.internal.type.DefaultType=MissingOverride +org.apache.maven.repository.legacy.DefaultUpdateCheckManager=UnusedLocalVariable,GuardLogStatement,UseTryWithResources +org.apache.maven.repository.legacy.DefaultWagonManager=UnusedFormalParameter,GuardLogStatement +org.apache.maven.repository.legacy.LegacyRepositorySystem=UnnecessaryFullyQualifiedName,MissingOverride,GuardLogStatement,AvoidReassigningParameters +org.apache.maven.repository.legacy.MavenArtifact=MissingOverride +org.apache.maven.repository.legacy.TransferListenerAdapter=MissingOverride +org.apache.maven.repository.legacy.UnknownRepositoryLayout=MissingOverride +org.apache.maven.repository.legacy.metadata.AbstractArtifactMetadata=MissingOverride +org.apache.maven.repository.legacy.metadata.DefaultMetadataResolutionRequest=MissingOverride +org.apache.maven.repository.legacy.metadata.MetadataResolutionRequest=MissingOverride +org.apache.maven.repository.legacy.repository.DefaultArtifactRepositoryFactory=MissingOverride,AvoidReassigningParameters +org.apache.maven.repository.legacy.resolver.DefaultLegacyArtifactCollector=CollapsibleIfStatements,MissingOverride,AvoidReassigningParameters,LooseCoupling,GuardLogStatement +org.apache.maven.repository.legacy.resolver.conflict.DefaultConflictResolverFactory=MissingOverride,PreserveStackTrace +org.apache.maven.repository.legacy.resolver.conflict.FarthestConflictResolver=MissingOverride +org.apache.maven.repository.legacy.resolver.conflict.NearestConflictResolver=MissingOverride +org.apache.maven.repository.legacy.resolver.conflict.NewestConflictResolver=MissingOverride +org.apache.maven.repository.legacy.resolver.conflict.OldestConflictResolver=MissingOverride +org.apache.maven.repository.legacy.resolver.transform.AbstractVersionTransformation=MissingOverride,GuardLogStatement +org.apache.maven.repository.legacy.resolver.transform.DefaultArtifactTransformationManager=MissingOverride +org.apache.maven.repository.legacy.resolver.transform.LatestArtifactTransformation=MissingOverride +org.apache.maven.repository.legacy.resolver.transform.SnapshotTransformation=UselessParentheses,MissingOverride,GuardLogStatement +org.apache.maven.repository.metadata.ArtifactMetadata=UnusedFormalParameter +org.apache.maven.repository.metadata.ClasspathContainer=MissingOverride,UseCollectionIsEmpty +org.apache.maven.repository.metadata.ClasspathGraphVisitor=UseCollectionIsEmpty +org.apache.maven.repository.metadata.DefaultClasspathTransformation=MissingOverride +org.apache.maven.repository.metadata.DefaultGraphConflictResolutionPolicy=MissingOverride +org.apache.maven.repository.metadata.DefaultGraphConflictResolver=UnusedFormalParameter,MissingOverride,LooseCoupling,UseCollectionIsEmpty +org.apache.maven.repository.metadata.MetadataGraph=UnusedFormalParameter,LooseCoupling,UseCollectionIsEmpty +org.apache.maven.repository.metadata.MetadataGraphEdge=OverrideBothEqualsAndHashcode,UselessParentheses,UnusedAssignment +org.apache.maven.repository.metadata.MetadataGraphVertex=MissingOverride +org.apache.maven.repository.metadata.MetadataTreeNode=MethodReturnsInternalArray,UseVarargs,ArrayIsStoredDirectly +org.apache.maven.resolver.Key=MissingOverride +org.apache.maven.resolver.MavenChainedWorkspaceReader=LooseCoupling +org.apache.maven.rtinfo.internal.DefaultRuntimeInformation=GuardLogStatement +org.apache.maven.session.scope.internal.SessionScope=MissingOverride +org.apache.maven.settings.DefaultMavenSettingsBuilder=UnnecessaryFullyQualifiedName,MissingOverride +org.apache.maven.settings.building.DefaultSettingsBuilder=UnusedFormalParameter,AvoidReassigningParameters +org.apache.maven.settings.building.DefaultSettingsProblemCollector=AvoidReassigningParameters +org.apache.maven.settings.crypto.DefaultSettingsDecrypter=AvoidReassigningLoopVariables +org.apache.maven.slf4j.DefaultLogLevelRecorder=CollapsibleIfStatements,AvoidBranchingStatementAsLastInLoop +org.apache.maven.slf4j.MavenBaseLogger=MissingOverride +org.apache.maven.slf4j.MavenServiceProvider=MissingOverride +org.apache.maven.slf4j.MavenSimpleLogger=MissingOverride +org.apache.maven.slf4j.SimpleLoggerConfiguration=GuardLogStatement,UselessParentheses +org.apache.maven.toolchain.DefaultToolchainsBuilder=MissingOverride +org.apache.maven.toolchain.building.DefaultToolchainsBuilder=UnusedFormalParameter,AvoidReassigningParameters +org.apache.maven.toolchain.java.JavaToolchainFactory=MissingOverride +org.apache.maven.toolchain.java.JavaToolchainImpl=MissingOverride +org.eclipse.sisu.plexus.PlexusXmlBeanConverter=MissingOverride,GuardLogStatement,PreserveStackTrace Review Comment: not in the codebase ########## .gitignore: ########## @@ -16,4 +16,5 @@ .factorypath .vscode/ repo/ -/*.svg \ No newline at end of file +/*.svg +/**/.cache Review Comment: Where is that needed and why would we ignore any `.cache` subfolder at any level of the tree? ########## .pmd/exclude.properties: ########## @@ -0,0 +1,483 @@ +org.apache.maven.AbstractMavenLifecycleParticipant=AbstractClassWithoutAbstractMethod Review Comment: I am not sure that all of those (or even the majority) are actually in the code base. If you want to add supressions, add `@SuppressWarnings("PMD.<xxx>") statements at the places where the problems occur. That way, an IDE can pick them up and point out when a suppression is no longer needed. Having a big central file is a sure recipe for this to fall into disrepair and things never getting fixed. Which is counter to what you are trying to accomplish. Suppressions need to be applied surgically in the right place where a violation exist. Not as a blanked "We cover the whole class" ########## pom.xml: ########## @@ -799,13 +799,30 @@ under the License.</licenseText> <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-pmd-plugin</artifactId> + <configuration> + <analysisCache>true</analysisCache> + <excludeFromFailureFile>.pmd/exclude.properties</excludeFromFailureFile> + <printFailingErrors>true</printFailingErrors> + <rulesets> + <ruleset>category/java/bestpractices.xml</ruleset> Review Comment: why would we not apply all java rulesets but only one? ########## .pmd/exclude.properties: ########## @@ -0,0 +1,483 @@ +org.apache.maven.AbstractMavenLifecycleParticipant=AbstractClassWithoutAbstractMethod +org.apache.maven.DefaultArtifactFilterManager=MissingOverride +org.apache.maven.DefaultMaven=GuardLogStatement +org.apache.maven.DefaultProjectDependenciesResolver=MissingOverride +org.apache.maven.MavenArtifactTypeRegistry=MissingOverride +org.apache.maven.ReactorReader=UselessParentheses,MissingOverride,GuardLogStatement +org.apache.maven.RepositoryUtils=ForLoopVariableCount +org.apache.maven.api.ChildrenPointer=MissingOverride +org.apache.maven.api.DefaultExtensibleEnum=MissingOverride +org.apache.maven.api.DefaultPathScope=UseEnumCollections +org.apache.maven.api.DependenciesPointer=MissingOverride +org.apache.maven.api.DependencyScope=UnnecessaryFullyQualifiedName +org.apache.maven.api.ExtensibleEnums=AbstractClassWithoutAbstractMethod +org.apache.maven.api.JavaPathType=UnnecessaryModifier,UnnecessaryFullyQualifiedName +org.apache.maven.api.Language=ConstantsInInterface +org.apache.maven.api.MonotonicClock=UnnecessaryFullyQualifiedName +org.apache.maven.api.Packaging=MissingOverride +org.apache.maven.api.PhasePointer=MissingOverride +org.apache.maven.api.ProjectScope=ConstantsInInterface +org.apache.maven.api.Type=MissingOverride +org.apache.maven.api.Version=MissingOverride +org.apache.maven.api.VersionConstraint=MissingOverride +org.apache.maven.api.VersionRange=MissingOverride +org.apache.maven.api.cli.mvn.MavenOptions=MissingOverride +org.apache.maven.api.cli.mvnenc.EncryptOptions=MissingOverride +org.apache.maven.api.cli.mvnsh.ShellOptions=MissingOverride +org.apache.maven.api.model.InputLocation=MissingOverride +org.apache.maven.api.plugin.testing.Foo=UnnecessaryFullyQualifiedName +org.apache.maven.api.plugin.testing.MojoExtension=CollapsibleIfStatements,UseVarargs +org.apache.maven.api.plugin.testing.stubs.PluginStub=MissingOverride +org.apache.maven.api.plugin.testing.stubs.RepositorySystemSupplier=LooseCoupling +org.apache.maven.api.plugin.testing.stubs.SessionMock=TooManyStaticImports +org.apache.maven.api.plugin.testing.stubs.SessionStub=LooseCoupling +org.apache.maven.api.services.ArtifactCoordinatesFactoryRequest=UnnecessaryFullyQualifiedName +org.apache.maven.api.services.ArtifactFactoryRequest=UnnecessaryFullyQualifiedName +org.apache.maven.api.services.BaseRequest=MissingOverride +org.apache.maven.api.services.DefaultArtifactFactoryRequestArtifact=MissingOverride +org.apache.maven.api.services.DefaultDependencyCoordinatesFactoryRequest=MissingOverride +org.apache.maven.api.services.DependencyCoordinatesFactoryRequest=UnnecessaryFullyQualifiedName +org.apache.maven.api.services.MessageBuilder=UseVarargs +org.apache.maven.api.services.ModelBuilderResult=MissingOverride +org.apache.maven.api.services.xml.DefaultXmlReaderRequest=MissingOverride +org.apache.maven.api.spi.PropertyContributor=LooseCoupling +org.apache.maven.api.xml.Impl=UnusedAssignment,AvoidReassigningParameters +org.apache.maven.artifact.ArtifactStatus=MissingOverride +org.apache.maven.artifact.ArtifactUtils=UnnecessaryFullyQualifiedName +org.apache.maven.artifact.DefaultArtifact=UselessParentheses,AvoidReassigningParameters,LiteralsFirstInComparisons +org.apache.maven.artifact.InvalidArtifactRTException=MissingOverride +org.apache.maven.artifact.deployer.DefaultArtifactDeployer=EmptyControlStatement,MissingOverride +org.apache.maven.artifact.factory.DefaultArtifactFactory=MissingOverride +org.apache.maven.artifact.handler.manager.DefaultArtifactHandlerManager=CollapsibleIfStatements,LooseCoupling +org.apache.maven.artifact.handler.manager.LegacyArtifactHandlerManager=CollapsibleIfStatements +org.apache.maven.artifact.installer.DefaultArtifactInstaller=EmptyControlStatement,MissingOverride +org.apache.maven.artifact.manager.DefaultWagonManager=MissingOverride,AvoidReassigningLoopVariables,GuardLogStatement,AvoidReassigningParameters +org.apache.maven.artifact.metadata.AbstractArtifactMetadata=UnnecessaryFullyQualifiedName +org.apache.maven.artifact.metadata.ArtifactMetadataSource=MissingOverride +org.apache.maven.artifact.repository.ArtifactMetadataAdapter=MissingOverride +org.apache.maven.artifact.repository.ArtifactRepositoryAdapter=MissingOverride +org.apache.maven.artifact.repository.ArtifactRepositoryPolicy=UnnecessaryFullyQualifiedName,AvoidReassigningParameters +org.apache.maven.artifact.repository.DefaultArtifactRepository=UnusedFormalParameter,AvoidReassigningParameters,MissingOverride +org.apache.maven.artifact.repository.DefaultArtifactRepositoryFactory=MissingOverride,PreserveStackTrace +org.apache.maven.artifact.repository.DefaultRepositoryRequest=MissingOverride +org.apache.maven.artifact.repository.LegacyLocalRepositoryManager=AvoidReassigningParameters,MissingOverride +org.apache.maven.artifact.repository.MavenArtifactRepository=MissingOverride,LiteralsFirstInComparisons +org.apache.maven.artifact.repository.layout.DefaultRepositoryLayout=MissingOverride +org.apache.maven.artifact.repository.layout.FlatRepositoryLayout=MissingOverride +org.apache.maven.artifact.repository.metadata.AbstractRepositoryMetadata=UnnecessaryFullyQualifiedName,MissingOverride +org.apache.maven.artifact.repository.metadata.ArtifactRepositoryMetadata=MissingOverride +org.apache.maven.artifact.repository.metadata.DefaultRepositoryMetadataManager=CollapsibleIfStatements,MissingOverride,GuardLogStatement +org.apache.maven.artifact.repository.metadata.GroupRepositoryMetadata=MissingOverride +org.apache.maven.artifact.repository.metadata.MetadataBridge=MissingOverride +org.apache.maven.artifact.repository.metadata.SnapshotArtifactRepositoryMetadata=MissingOverride +org.apache.maven.artifact.repository.metadata.io.DefaultMetadataReader=MissingOverride +org.apache.maven.artifact.repository.metadata.io.xpp3.MetadataXpp3Writer=UnnecessaryFullyQualifiedName +org.apache.maven.artifact.resolver.AbstractArtifactResolutionException=ForLoopCanBeForeach +org.apache.maven.artifact.resolver.ArtifactResolutionRequest=MissingOverride +org.apache.maven.artifact.resolver.ArtifactResolutionResult=MissingOverride +org.apache.maven.artifact.resolver.CyclicDependencyException=MissingOverride +org.apache.maven.artifact.resolver.DaemonThreadCreator=AvoidThreadGroup,MissingOverride +org.apache.maven.artifact.resolver.DebugResolutionListener=MissingOverride,GuardLogStatement +org.apache.maven.artifact.resolver.DefaultArtifactResolver=MissingOverride,PreserveStackTrace,GuardLogStatement +org.apache.maven.artifact.resolver.DefaultResolutionErrorHandler=MissingOverride +org.apache.maven.artifact.resolver.ResolveTask=MissingOverride +org.apache.maven.artifact.resolver.WarningResolutionListener=MissingOverride +org.apache.maven.artifact.resolver.filter.AbstractScopeArtifactFilter=MissingOverride +org.apache.maven.artifact.resolver.filter.AndArtifactFilter=MissingOverride +org.apache.maven.artifact.resolver.filter.ExcludesArtifactFilter=MissingOverride +org.apache.maven.artifact.resolver.filter.ExclusionArtifactFilter=UnusedPrivateField +org.apache.maven.artifact.resolver.filter.ExclusionSetFilter=UseVarargs,MissingOverride +org.apache.maven.artifact.resolver.filter.IncludesArtifactFilter=MissingOverride +org.apache.maven.artifact.resolver.filter.InversionArtifactFilter=MissingOverride +org.apache.maven.artifact.resolver.filter.OrArtifactFilter=MissingOverride +org.apache.maven.artifact.resolver.filter.TypeArtifactFilter=UnusedAssignment,MissingOverride +org.apache.maven.artifact.versioning.BigIntegerItem=MissingOverride +org.apache.maven.artifact.versioning.CombinationItem=UnusedAssignment +org.apache.maven.artifact.versioning.ComparableVersion=UselessParentheses,LooseCoupling,AvoidReassigningParameters,AvoidReassigningLoopVariables,SystemPrintln +org.apache.maven.artifact.versioning.DefaultArtifactVersion=MissingOverride +org.apache.maven.artifact.versioning.ListItem=UselessParentheses,LooseCoupling +org.apache.maven.artifact.versioning.ManagedVersionMap=MissingOverride +org.apache.maven.artifact.versioning.Restriction=MissingOverride +org.apache.maven.artifact.versioning.StringItem=AvoidReassigningParameters,LiteralsFirstInComparisons,MissingOverride +org.apache.maven.artifact.versioning.VersionRange=CollapsibleIfStatements,UseCollectionIsEmpty,MissingOverride +org.apache.maven.bridge.MavenRepositorySystem=UnnecessaryFullyQualifiedName,AvoidUsingHardCodedIP,UselessParentheses,AvoidReassigningParameters,LiteralsFirstInComparisons +org.apache.maven.building.DefaultProblem=MissingOverride +org.apache.maven.classrealm.ArtifactClassRealmConstituent=MissingOverride +org.apache.maven.classrealm.DefaultClassRealmManager=MissingOverride,AvoidReassigningParameters,GuardLogStatement +org.apache.maven.classrealm.DefaultClassRealmRequest=MissingOverride +org.apache.maven.cli.CLIManager=UseVarargs +org.apache.maven.cli.CLIReportingUtils=UselessParentheses,SystemPrintln,GuardLogStatement +org.apache.maven.cli.CleanArgument=UseVarargs,SystemPrintln +org.apache.maven.cli.CliRequest=ArrayIsStoredDirectly,MethodReturnsInternalArray +org.apache.maven.cli.ExtensionInterpolator=MissingOverride +org.apache.maven.cli.MavenCli=UnnecessaryFullyQualifiedName,UselessParentheses,SystemPrintln,LiteralsFirstInComparisons,GuardLogStatement,AvoidPrintStackTrace,AvoidReassigningParameters,PreserveStackTrace +org.apache.maven.cli.configuration.SettingsXmlConfigurationProcessor=UnusedFormalParameter,GuardLogStatement +org.apache.maven.cli.event.DefaultEventSpyContext=MissingOverride +org.apache.maven.cli.event.ExecutionEventLogger=GuardLogStatement +org.apache.maven.cli.internal.BootstrapCoreExtensionManager=GuardLogStatement +org.apache.maven.cli.logging.Slf4jStdoutLogger=MissingOverride +org.apache.maven.cli.props.MavenProperties=CollapsibleIfStatements,MissingOverride,AvoidReassigningParameters,LooseCoupling +org.apache.maven.cli.props.MavenPropertiesLoader=UselessParentheses,LooseCoupling +org.apache.maven.cli.transfer.AbstractMavenTransferListener=UselessParentheses +org.apache.maven.cli.transfer.ConsoleMavenTransferListener=UnusedFormalParameter,AvoidReassigningParameters +org.apache.maven.cli.transfer.FileSizeFormat=AvoidReassigningParameters +org.apache.maven.cli.transfer.SimplexTransferListener=LooseCoupling +org.apache.maven.cli.transfer.Slf4jMavenTransferListener=UselessParentheses,GuardLogStatement +org.apache.maven.cling.ClingSupport=UseTryWithResources,GuardLogStatement,UseVarargs +org.apache.maven.cling.event.ExecutionEventLogger=GuardLogStatement +org.apache.maven.cling.executor.embedded.Context=UnusedPrivateField +org.apache.maven.cling.executor.embedded.EmbeddedMavenExecutor=LooseCoupling,UnnecessaryVarargsArrayCreation,UseTryWithResources +org.apache.maven.cling.executor.forked.ForkedMavenExecutor=LooseCoupling +org.apache.maven.cling.executor.internal.HelperImpl=LooseCoupling,UseEnumCollections +org.apache.maven.cling.executor.internal.ToolboxTool=SystemPrintln +org.apache.maven.cling.extensions.BootstrapCoreExtensionManager=GuardLogStatement +org.apache.maven.cling.extensions.ExtensionInterpolator=MissingOverride +org.apache.maven.cling.invoker.BaseParser=TooManyStaticImports,GuardLogStatement,LiteralsFirstInComparisons,LooseCoupling +org.apache.maven.cling.invoker.CLIManager=LooseCoupling,UseVarargs +org.apache.maven.cling.invoker.CleanArgument=UseVarargs,SystemPrintln +org.apache.maven.cling.invoker.CliUtils=AvoidReassigningParameters,LooseCoupling +org.apache.maven.cling.invoker.LayeredOptions=LooseCoupling +org.apache.maven.cling.invoker.LookupInvoker=SimplifiedTernary,AvoidReassigningParameters,GuardLogStatement,LooseCoupling,PreserveStackTrace +org.apache.maven.cling.invoker.PlexusContainerCapsuleFactory=LooseCoupling,GuardLogStatement +org.apache.maven.cling.invoker.PrecedenceCoreExtensionSelector=GuardLogStatement,LooseCoupling +org.apache.maven.cling.invoker.cisupport.CIDetectorHelper=LooseCoupling +org.apache.maven.cling.invoker.mvn.CommonsCliMavenOptions=UseVarargs +org.apache.maven.cling.invoker.mvn.LayeredMavenOptions=LooseCoupling +org.apache.maven.cling.invoker.mvn.MavenInvoker=GuardLogStatement,AvoidReassigningParameters +org.apache.maven.cling.invoker.mvn.MavenInvokerRequest=MissingOverride +org.apache.maven.cling.invoker.mvn.MavenParser=LooseCoupling,PreserveStackTrace +org.apache.maven.cling.invoker.mvn.resident.ResidentMavenInvoker=LooseCoupling +org.apache.maven.cling.invoker.mvnenc.CommonsCliEncryptOptions=UnnecessaryFullyQualifiedName,UseVarargs +org.apache.maven.cling.invoker.mvnenc.EncryptInvoker=GuardLogStatement +org.apache.maven.cling.invoker.mvnenc.EncryptInvokerRequest=MissingOverride +org.apache.maven.cling.invoker.mvnenc.goals.ConfiguredGoalSupport=GuardLogStatement +org.apache.maven.cling.invoker.mvnenc.goals.Init=GuardLogStatement +org.apache.maven.cling.invoker.mvnsh.CommonsCliShellOptions=UnnecessaryFullyQualifiedName,UseVarargs +org.apache.maven.cling.invoker.mvnsh.ShellCommandRegistryHolder=LooseCoupling +org.apache.maven.cling.invoker.mvnsh.ShellInvokerRequest=MissingOverride +org.apache.maven.cling.invoker.mvnsh.builtin.BuiltinShellCommandRegistry=UnusedFormalParameter,GuardLogStatement +org.apache.maven.cling.invoker.mvnsh.builtin.BuiltinShellCommandRegistryFactory=MissingOverride +org.apache.maven.cling.logging.Slf4jLoggerManager=UselessParentheses +org.apache.maven.cling.logging.impl.MavenSimpleConfiguration=GuardLogStatement +org.apache.maven.cling.logging.impl.UnsupportedSlf4jBindingConfiguration=UnusedFormalParameter +org.apache.maven.cling.props.MavenProperties=CollapsibleIfStatements,MissingOverride,AvoidReassigningParameters,LooseCoupling +org.apache.maven.cling.props.MavenPropertiesLoader=UselessParentheses,LooseCoupling +org.apache.maven.cling.transfer.AbstractMavenTransferListener=UselessParentheses +org.apache.maven.cling.transfer.ConsoleMavenTransferListener=UnusedFormalParameter,AvoidStringBufferField,AvoidReassigningParameters +org.apache.maven.cling.transfer.FileSizeFormat=AvoidReassigningParameters +org.apache.maven.cling.transfer.SimplexTransferListener=LooseCoupling +org.apache.maven.cling.transfer.Slf4jMavenTransferListener=UselessParentheses,GuardLogStatement +org.apache.maven.cling.utils.CLIReportingUtils=UnusedPrivateField,UselessParentheses,SystemPrintln,GuardLogStatement +org.apache.maven.configuration.BasedirBeanConfigurationPathTranslator=EmptyControlStatement,MissingOverride +org.apache.maven.configuration.DefaultBeanConfigurationRequest=MissingOverride +org.apache.maven.configuration.internal.BeanExpressionEvaluator=MissingOverride +org.apache.maven.configuration.internal.DefaultBeanConfigurator=MissingOverride +org.apache.maven.configuration.internal.EnhancedConfigurationConverter=MissingOverride +org.apache.maven.di.Key=AbstractClassWithoutAbstractMethod +org.apache.maven.di.impl.Binding=UseVarargs,ArrayIsStoredDirectly,UnnecessaryFullyQualifiedName +org.apache.maven.di.impl.BindingToConstructor=ArrayIsStoredDirectly +org.apache.maven.di.impl.InjectorImpl=LooseCoupling +org.apache.maven.di.impl.ParameterizedTypeImpl=UseVarargs,ArrayIsStoredDirectly,MethodReturnsInternalArray +org.apache.maven.di.impl.ReflectionUtils=AvoidReassigningParameters,UnnecessaryFullyQualifiedName +org.apache.maven.di.impl.SingletonScope=UnnecessaryFullyQualifiedName +org.apache.maven.di.impl.Types=JumbledIncrementer,UnnecessaryFullyQualifiedName,UseVarargs,AvoidReassigningLoopVariables,OneDeclarationPerLine,AvoidReassigningParameters +org.apache.maven.di.impl.WildcardTypeImpl=UseVarargs,ArrayIsStoredDirectly,MethodReturnsInternalArray +org.apache.maven.eventspy.AbstractEventSpy=MissingOverride +org.apache.maven.exception.DefaultExceptionHandler=UselessParentheses,AvoidReassigningParameters +org.apache.maven.execution.AbstractExecutionListener=MissingOverride +org.apache.maven.execution.BuildSummary=AbstractClassWithoutAbstractMethod +org.apache.maven.execution.DefaultMavenExecutionRequestPopulator=AvoidReassigningLoopVariables +org.apache.maven.execution.DefaultMavenExecutionResult=MissingOverride +org.apache.maven.execution.DefaultRuntimeInformation=MissingOverride +org.apache.maven.execution.MavenSession=UnusedFormalParameter,UnnecessaryVarargsArrayCreation +org.apache.maven.execution.scope.internal.MojoExecutionScope=MissingOverride,LooseCoupling +org.apache.maven.extension.internal.CoreExportsProvider=MissingOverride +org.apache.maven.graph.DefaultGraphBuilder=UselessParentheses,GuardLogStatement +org.apache.maven.graph.DefaultProjectDependencyGraph=MissingOverride +org.apache.maven.impl.AetherDependencyWrapper=AbstractClassWithoutAbstractMethod +org.apache.maven.impl.DefaultChecksumAlgorithmService=LooseCoupling +org.apache.maven.impl.DefaultDependencyResolverResult=AvoidReassigningLoopVariables +org.apache.maven.impl.DefaultMessageBuilder=AvoidStringBufferField +org.apache.maven.impl.DefaultNode=UnnecessaryFullyQualifiedName,UselessParentheses +org.apache.maven.impl.DefaultPluginConfigurationExpander=AvoidReassigningParameters +org.apache.maven.impl.DefaultPluginXmlFactory=UnusedLocalVariable +org.apache.maven.impl.DefaultRepositoryFactory=UnnecessaryFullyQualifiedName +org.apache.maven.impl.DefaultSettingsBuilder=UnusedFormalParameter +org.apache.maven.impl.DefaultSourceRoot=AvoidReassigningParameters +org.apache.maven.impl.DefaultToolchainManager=GuardLogStatement,LooseCoupling +org.apache.maven.impl.DefaultToolchainsBuilder=UnusedFormalParameter +org.apache.maven.impl.DefaultTransportProvider=UnnecessaryFullyQualifiedName +org.apache.maven.impl.ExcludeFromFailureFile=SystemPrintln,AvoidPrintStackTrace +org.apache.maven.impl.InternalSession=UnnecessaryFullyQualifiedName +org.apache.maven.impl.PathModularization=PreserveStackTrace +org.apache.maven.impl.PathSelector=AvoidReassigningParameters,UseVarargs,NonExhaustiveSwitch,AvoidReassigningLoopVariables +org.apache.maven.impl.PropertiesAsMap=UnnecessaryFullyQualifiedName +org.apache.maven.impl.RequestTraceHelper=AvoidReassigningParameters +org.apache.maven.impl.SettingsUtilsV4=UnnecessaryFullyQualifiedName +org.apache.maven.impl.cache.DefaultRequestCache=MissingOverride +org.apache.maven.impl.cache.DefaultRequestCacheFactory=MissingOverride +org.apache.maven.impl.cache.SoftIdentityMap=LooseCoupling +org.apache.maven.impl.di.MojoExecutionScope=LooseCoupling,MissingOverride +org.apache.maven.impl.di.SessionScope=UseVarargs +org.apache.maven.impl.model.DefaultInheritanceAssembler=UselessParentheses,AvoidReassigningLoopVariables +org.apache.maven.impl.model.DefaultInterpolator=AvoidReassigningParameters +org.apache.maven.impl.model.DefaultLifecycleBindingsInjector=MissingOverride +org.apache.maven.impl.model.DefaultModelBuilder=MissingOverride,AvoidReassigningLoopVariables,LiteralsFirstInComparisons,UnnecessaryFullyQualifiedName +org.apache.maven.impl.model.DefaultModelBuilderResult=MissingOverride +org.apache.maven.impl.model.DefaultModelInterpolator=AvoidReassigningParameters,LiteralsFirstInComparisons,EmptyControlStatement +org.apache.maven.impl.model.DefaultModelNormalizer=AvoidReassigningLoopVariables +org.apache.maven.impl.model.DefaultModelPathTranslator=AvoidReassigningParameters +org.apache.maven.impl.model.DefaultModelProblem=MissingOverride +org.apache.maven.impl.model.DefaultModelProcessor=AvoidReassigningParameters +org.apache.maven.impl.model.DefaultModelValidator=LooseCoupling,ForLoopVariableCount,UseVarargs,AvoidReassigningParameters,UnnecessaryFullyQualifiedName +org.apache.maven.impl.model.DefaultPathTranslator=AvoidReassigningParameters +org.apache.maven.impl.model.DefaultProfileActivationContext=OneDeclarationPerLine +org.apache.maven.impl.model.DefaultProfileInjector=AvoidReassigningParameters +org.apache.maven.impl.model.Graph=LooseCoupling +org.apache.maven.impl.model.InheritanceModelMerger=AvoidReassigningLoopVariables +org.apache.maven.impl.model.InliningTransformer=MissingOverride +org.apache.maven.impl.model.LifecycleBindingsMerger=AvoidReassigningLoopVariables +org.apache.maven.impl.model.ManagementModelMerger=AvoidReassigningLoopVariables +org.apache.maven.impl.model.MavenBuildTimestamp=AvoidReassigningParameters +org.apache.maven.impl.model.MavenModelMerger=ForLoopVariableCount,OneDeclarationPerLine,AvoidReassigningLoopVariables +org.apache.maven.impl.model.ModelBuilderSessionState=PreserveStackTrace,AvoidReassigningParameters,GuardLogStatement,MissingOverride,CollapsibleIfStatements,AvoidReassigningLoopVariables +org.apache.maven.impl.model.ProfileModelMerger=AvoidReassigningLoopVariables +org.apache.maven.impl.model.Record=UseEnumCollections +org.apache.maven.impl.model.profile.ConditionParser=AvoidReassigningLoopVariables,LiteralsFirstInComparisons,PreserveStackTrace +org.apache.maven.impl.model.profile.JdkVersionProfileActivator=AvoidReassigningParameters +org.apache.maven.impl.model.reflection.ClassMap=ReplaceHashtableWithMap,AvoidReassigningLoopVariables,AvoidReassigningParameters +org.apache.maven.impl.model.reflection.MethodMap=ReplaceHashtableWithMap,LooseCoupling,UseVarargs +org.apache.maven.impl.model.rootlocator.DefaultRootLocator=MissingOverride,GuardLogStatement +org.apache.maven.impl.model.rootlocator.PomXmlRootDetector=LiteralsFirstInComparisons +org.apache.maven.impl.resolver.DefaultArtifactDescriptorReader=LooseCoupling,AvoidReassigningLoopVariables,PreserveStackTrace,GuardLogStatement +org.apache.maven.impl.resolver.DefaultModelResolver=MissingOverride +org.apache.maven.impl.resolver.LocalSnapshotMetadataGenerator=UnusedFormalParameter +org.apache.maven.impl.resolver.MavenMetadata=MissingOverride +org.apache.maven.impl.resolver.PluginsMetadata=LooseCoupling +org.apache.maven.impl.resolver.PluginsMetadataGenerator=LooseCoupling,GuardLogStatement +org.apache.maven.impl.resolver.RemoteSnapshotMetadataGenerator=AvoidReassigningParameters +org.apache.maven.impl.resolver.relocation.DistributionManagementArtifactRelocationSource=GuardLogStatement +org.apache.maven.impl.resolver.relocation.UserPropertiesArtifactRelocationSource=GuardLogStatement +org.apache.maven.impl.resolver.scopes.Maven3ScopeManagerConfiguration=LooseCoupling,TooManyStaticImports,UnnecessaryFullyQualifiedName +org.apache.maven.impl.resolver.scopes.Maven4ScopeManagerConfiguration=LooseCoupling,TooManyStaticImports,UnnecessaryFullyQualifiedName +org.apache.maven.impl.resolver.type.DefaultType=MissingOverride +org.apache.maven.impl.standalone.DefaultSession=LooseCoupling +org.apache.maven.internal.aether.DefaultRepositorySystemSessionFactory=EmptyControlStatement,MissingOverride,GuardLogStatement,LooseCoupling +org.apache.maven.internal.aether.LoggingRepositoryListener=GuardLogStatement +org.apache.maven.internal.aether.ReverseTreeRepositoryListener=LooseCoupling,AvoidReassigningParameters +org.apache.maven.internal.impl.CleanLifecycle=UnnecessaryFullyQualifiedName +org.apache.maven.internal.impl.DefaultLifecycle=UnnecessaryFullyQualifiedName +org.apache.maven.internal.impl.DefaultLifecycleRegistry=UnnecessaryFullyQualifiedName,TooManyStaticImports,MissingOverride +org.apache.maven.internal.impl.DefaultLog=MissingOverride,GuardLogStatement +org.apache.maven.internal.impl.DefaultPackagingRegistry=AvoidReassigningParameters,OneDeclarationPerLine,GuardLogStatement +org.apache.maven.internal.impl.DefaultProject=LooseCoupling +org.apache.maven.internal.impl.DefaultProjectManager=LooseCoupling,AvoidReassigningParameters +org.apache.maven.internal.impl.DefaultSession=MissingOverride,LooseCoupling +org.apache.maven.internal.impl.DefaultTypeRegistry=CollapsibleIfStatements,LooseCoupling +org.apache.maven.internal.impl.Graph=LooseCoupling +org.apache.maven.internal.impl.SiteLifecycle=UnnecessaryFullyQualifiedName +org.apache.maven.internal.transformation.impl.DefaultConsumerPomArtifactTransformer=UnusedPrivateMethod,MissingOverride,LooseCoupling,AvoidReassigningParameters +org.apache.maven.internal.transformation.impl.DefaultConsumerPomBuilder=UnusedFormalParameter,AvoidReassigningParameters,GuardLogStatement +org.apache.maven.internal.xml.DefaultXmlService=MissingOverride,UseVarargs,UnusedPrivateMethod +org.apache.maven.internal.xml.XmlNodeImpl=MissingOverride,UnusedAssignment,AvoidReassigningParameters +org.apache.maven.internal.xml.XmlPlexusConfiguration=ForLoopVariableCount +org.apache.maven.jline.DefaultPrompter=UselessParentheses,AvoidReassigningParameters +org.apache.maven.jline.MavenStyleResolver=AvoidReassigningParameters +org.apache.maven.jline.MessageUtils=UnnecessaryFullyQualifiedName +org.apache.maven.lifecycle.DefaultLifecycleExecutor=MissingOverride +org.apache.maven.lifecycle.DefaultLifecycles=UnusedFormalParameter +org.apache.maven.lifecycle.LifecycleExecutionException=UnusedFormalParameter +org.apache.maven.lifecycle.MavenExecutionPlan=LooseCoupling,MissingOverride +org.apache.maven.lifecycle.internal.DefaultLifecycleExecutionPlanCalculator=UselessParentheses +org.apache.maven.lifecycle.internal.DefaultLifecycleMappingDelegate=AvoidReassigningParameters +org.apache.maven.lifecycle.internal.DefaultLifecyclePluginAnalyzer=GuardLogStatement +org.apache.maven.lifecycle.internal.DefaultLifecycleStarter=UnusedAssignment,GuardLogStatement +org.apache.maven.lifecycle.internal.DefaultLifecycleTaskSegmentCalculator=UselessParentheses,AvoidReassigningLoopVariables +org.apache.maven.lifecycle.internal.DefaultMojoExecutionConfigurator=GuardLogStatement +org.apache.maven.lifecycle.internal.DefaultProjectArtifactFactory=AvoidReassigningParameters +org.apache.maven.lifecycle.internal.LifecycleDebugLogger=GuardLogStatement +org.apache.maven.lifecycle.internal.LifecycleDependencyResolver=AvoidReassigningParameters +org.apache.maven.lifecycle.internal.LifecycleModuleBuilder=PreserveStackTrace +org.apache.maven.lifecycle.internal.MojoDescriptorCreator=GuardLogStatement +org.apache.maven.lifecycle.internal.MojoExecutor=UnusedLocalVariable +org.apache.maven.lifecycle.internal.ReactorDependencyFilter=MissingOverride +org.apache.maven.lifecycle.internal.Task=AbstractClassWithoutAbstractMethod +org.apache.maven.lifecycle.internal.builder.BuilderCommon=EmptyControlStatement,GuardLogStatement +org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder=GuardLogStatement +org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder=MissingOverride +org.apache.maven.lifecycle.internal.concurrent.BuildContext=UnusedLocalVariable,CollapsibleIfStatements,EmptyControlStatement,GuardLogStatement +org.apache.maven.lifecycle.internal.concurrent.BuildPlanExecutor=TooManyStaticImports,UselessParentheses +org.apache.maven.lifecycle.internal.concurrent.BuildPlanLogger=LooseCoupling +org.apache.maven.lifecycle.internal.concurrent.ConcurrentLifecycleStarter=UselessParentheses,MissingOverride,GuardLogStatement,AvoidReassigningLoopVariables +org.apache.maven.lifecycle.providers.AbstractLifecycleProvider=UseVarargs,LooseCoupling +org.apache.maven.lifecycle.providers.packaging.AbstractLifecycleMappingProvider=UseVarargs,LooseCoupling +org.apache.maven.logging.LoggingExecutionListener=UselessParentheses +org.apache.maven.logging.ProjectBuildLogAppender=AvoidReassigningParameters +org.apache.maven.model.building.DefaultModelBuilder=AvoidReassigningLoopVariables,AvoidReassigningParameters,PreserveStackTrace,LooseCoupling,LiteralsFirstInComparisons +org.apache.maven.model.building.FileModelSource=AvoidReassigningParameters +org.apache.maven.model.building.Graph=LooseCoupling +org.apache.maven.model.building.ModelBuildingException=AvoidReassigningParameters +org.apache.maven.model.building.ModelProcessor=ConstantsInInterface +org.apache.maven.model.inheritance.DefaultInheritanceAssembler=AvoidReassigningLoopVariables +org.apache.maven.model.interpolation.InterpolateObjectAction=LooseCoupling +org.apache.maven.model.interpolation.ListField=ForLoopVariableCount +org.apache.maven.model.interpolation.MavenBuildTimestamp=AvoidReassigningParameters +org.apache.maven.model.interpolation.ModelVisitor=OneDeclarationPerLine,ForLoopVariableCount +org.apache.maven.model.interpolation.ObjectBasedValueSource=MissingOverride +org.apache.maven.model.interpolation.PathTranslatingPostProcessor=AvoidReassigningParameters +org.apache.maven.model.interpolation.PrefixedObjectValueSource=MissingOverride +org.apache.maven.model.interpolation.reflection.ClassMap=ReplaceHashtableWithMap,AvoidReassigningLoopVariables,AvoidReassigningParameters +org.apache.maven.model.interpolation.reflection.MethodMap=ReplaceHashtableWithMap,LooseCoupling,UseVarargs +org.apache.maven.model.io.xpp3.MavenXpp3WriterEx=MissingOverride +org.apache.maven.model.merge.MavenModelMerger=ForLoopVariableCount,OneDeclarationPerLine +org.apache.maven.model.merge.MergingList=LooseCoupling +org.apache.maven.model.merge.ModelMerger=LooseCoupling +org.apache.maven.model.path.DefaultPathTranslator=AvoidReassigningParameters +org.apache.maven.model.plugin.DefaultLifecycleBindingsInjector=MissingOverride +org.apache.maven.model.profile.activation.JdkVersionProfileActivator=AvoidReassigningParameters +org.apache.maven.model.root.DefaultRootLocator=MissingOverride,LiteralsFirstInComparisons +org.apache.maven.model.validation.DefaultModelValidator=UnusedFormalParameter,LooseCoupling,ForLoopVariableCount,AvoidReassigningParameters +org.apache.maven.monitor.logging.DefaultLog=GuardLogStatement,MissingOverride +org.apache.maven.plugin.CompoundMojoExecutionListener=MissingOverride +org.apache.maven.plugin.CycleDetectedInPluginGraphException=UnusedFormalParameter +org.apache.maven.plugin.DebugConfigurationListener=MissingOverride +org.apache.maven.plugin.DefaultExtensionRealmCache=MissingOverride +org.apache.maven.plugin.DefaultPluginArtifactsCache=MissingOverride +org.apache.maven.plugin.DefaultPluginDescriptorCache=MissingOverride +org.apache.maven.plugin.DefaultPluginRealmCache=MissingOverride,PreserveStackTrace +org.apache.maven.plugin.MavenPluginPrerequisitesChecker=MissingOverride +org.apache.maven.plugin.PluginConfigurationException=UnusedPrivateField +org.apache.maven.plugin.PluginParameterException=UselessParentheses,ForLoopCanBeForeach +org.apache.maven.plugin.PluginParameterExpressionEvaluator=UselessParentheses,EmptyControlStatement,LiteralsFirstInComparisons,AvoidReassigningParameters +org.apache.maven.plugin.PluginParameterExpressionEvaluatorV4=UselessParentheses,CollapsibleIfStatements,EmptyControlStatement,AvoidReassigningParameters +org.apache.maven.plugin.descriptor.MojoDescriptor=LooseCoupling,MissingOverride +org.apache.maven.plugin.descriptor.Parameter=MissingOverride +org.apache.maven.plugin.descriptor.PluginDescriptor=MissingOverride +org.apache.maven.plugin.internal.DefaultLegacySupport=UnnecessaryFullyQualifiedName,MissingOverride +org.apache.maven.plugin.internal.DefaultMavenPluginManager=MissingOverride,PreserveStackTrace,GuardLogStatement +org.apache.maven.plugin.internal.DefaultPluginDependenciesResolver=MissingOverride,AvoidReassigningParameters +org.apache.maven.plugin.internal.DefaultPluginManager=MissingOverride,PreserveStackTrace +org.apache.maven.plugin.internal.DefaultPluginValidationManager=GuardLogStatement,LooseCoupling +org.apache.maven.plugin.internal.DeprecatedCoreExpressionValidator=LooseCoupling +org.apache.maven.plugin.internal.MavenPluginMavenPrerequisiteChecker=UnusedAssignment,GuardLogStatement +org.apache.maven.plugin.internal.MojoLogWrapper=MissingOverride +org.apache.maven.plugin.internal.PlexusContainerDefaultDependenciesValidator=MissingOverride +org.apache.maven.plugin.internal.PluginValidationIssues=LooseCoupling,UseEnumCollections +org.apache.maven.plugin.internal.ValidatingConfigurationListener=MissingOverride +org.apache.maven.plugin.logging.SystemStreamLog=MissingOverride,SystemPrintln +org.apache.maven.plugin.prefix.DefaultPluginPrefixRequest=MissingOverride +org.apache.maven.plugin.prefix.internal.DefaultPluginPrefixResolver=UselessParentheses,MissingOverride,GuardLogStatement +org.apache.maven.plugin.prefix.internal.DefaultPluginPrefixResult=MissingOverride +org.apache.maven.plugin.version.DefaultPluginVersionRequest=MissingOverride +org.apache.maven.plugin.version.internal.DefaultPluginVersionResolver=GuardLogStatement,LooseCoupling +org.apache.maven.plugin.version.internal.DefaultPluginVersionResult=MissingOverride +org.apache.maven.profiles.DefaultProfileManager=MissingOverride,GuardLogStatement +org.apache.maven.profiles.activation.DetectedProfileActivator=MissingOverride +org.apache.maven.profiles.activation.FileProfileActivator=MissingOverride,GuardLogStatement +org.apache.maven.profiles.activation.JdkPrefixProfileActivator=MissingOverride,PreserveStackTrace +org.apache.maven.profiles.activation.OperatingSystemProfileActivator=MissingOverride +org.apache.maven.profiles.activation.SystemPropertyProfileActivator=MissingOverride +org.apache.maven.project.BuildSession=UselessParentheses,LooseCoupling,GuardLogStatement +org.apache.maven.project.DefaultDependencyResolutionRequest=MissingOverride +org.apache.maven.project.DefaultDependencyResolutionResult=MissingOverride +org.apache.maven.project.DefaultMavenProjectBuilder=MissingOverride +org.apache.maven.project.DefaultMavenProjectHelper=MissingOverride +org.apache.maven.project.DefaultProjectBuilder=UnusedFormalParameter +org.apache.maven.project.DefaultProjectBuilderConfiguration=MissingOverride +org.apache.maven.project.DefaultProjectBuildingHelper=MissingOverride +org.apache.maven.project.DefaultProjectBuildingRequest=MissingOverride +org.apache.maven.project.DefaultProjectBuildingResult=MissingOverride +org.apache.maven.project.DefaultProjectDependenciesResolver=MissingOverride,GuardLogStatement +org.apache.maven.project.DefaultProjectRealmCache=MissingOverride +org.apache.maven.project.Graph=LooseCoupling +org.apache.maven.project.MavenProject=UselessParentheses,UnusedFormalParameter,CollapsibleIfStatements,AvoidReassigningParameters +org.apache.maven.project.ProjectModelResolver=MissingOverride +org.apache.maven.project.ProjectSorter=UselessParentheses +org.apache.maven.project.artifact.ActiveProjectArtifact=MissingOverride +org.apache.maven.project.artifact.AttachedArtifact=MissingOverride +org.apache.maven.project.artifact.DefaultMavenMetadataCache=ForLoopVariableCount,MissingOverride +org.apache.maven.project.artifact.DefaultProjectArtifactsCache=LooseCoupling +org.apache.maven.project.artifact.MavenMetadataSource=LiteralsFirstInComparisons,AvoidReassigningParameters,PreserveStackTrace,GuardLogStatement +org.apache.maven.project.artifact.PluginArtifact=MissingOverride +org.apache.maven.project.artifact.ProjectArtifact=MissingOverride +org.apache.maven.project.artifact.ProjectArtifactMetadata=MissingOverride +org.apache.maven.project.collector.DefaultProjectsSelector=UselessParentheses,GuardLogStatement +org.apache.maven.project.collector.MultiModuleCollectionStrategy=GuardLogStatement +org.apache.maven.project.interpolation.AbstractStringBasedModelInterpolator=MissingOverride,AvoidReassigningParameters,GuardLogStatement +org.apache.maven.project.interpolation.BuildTimestampValueSource=MissingOverride +org.apache.maven.project.interpolation.InterpolateObjectAction=LooseCoupling,MissingOverride,GuardLogStatement +org.apache.maven.project.interpolation.PathTranslatingPostProcessor=MissingOverride,AvoidReassigningParameters +org.apache.maven.project.interpolation.RegexBasedModelInterpolator=UnusedFormalParameter,MissingOverride +org.apache.maven.project.interpolation.StringSearchModelInterpolator=MissingOverride +org.apache.maven.project.path.DefaultPathTranslator=CollapsibleIfStatements,MissingOverride,AvoidReassigningParameters +org.apache.maven.project.validation.DefaultModelValidator=MissingOverride +org.apache.maven.project.validation.ModelValidationResult=MissingOverride,UseCollectionIsEmpty +org.apache.maven.project.validation.SimpleModelProblemCollector=MissingOverride +org.apache.maven.repository.ArtifactTransferEvent=MethodReturnsInternalArray,ArrayIsStoredDirectly,MissingOverride +org.apache.maven.repository.DefaultMirrorSelector=AvoidUsingHardCodedIP,UselessParentheses,MissingOverride,AvoidReassigningLoopVariables,LiteralsFirstInComparisons +org.apache.maven.repository.DelegatingLocalArtifactRepository=AvoidReassigningParameters,MissingOverride +org.apache.maven.repository.LocalArtifactRepository=MissingOverride +org.apache.maven.repository.MetadataResolutionRequest=MissingOverride +org.apache.maven.repository.MetadataResolutionResult=MissingOverride +org.apache.maven.repository.internal.DefaultArtifactDescriptorReader=LooseCoupling,AvoidReassigningLoopVariables,PreserveStackTrace,GuardLogStatement +org.apache.maven.repository.internal.DefaultModelResolver=UnnecessaryFullyQualifiedName +org.apache.maven.repository.internal.LocalSnapshotMetadataGenerator=UnusedFormalParameter +org.apache.maven.repository.internal.MavenMetadata=MissingOverride +org.apache.maven.repository.internal.PluginsMetadata=LooseCoupling +org.apache.maven.repository.internal.PluginsMetadataGenerator=LooseCoupling,GuardLogStatement +org.apache.maven.repository.internal.RemoteSnapshotMetadataGenerator=AvoidReassigningParameters +org.apache.maven.repository.internal.RequestTraceHelper=AvoidReassigningParameters +org.apache.maven.repository.internal.relocation.DistributionManagementArtifactRelocationSource=GuardLogStatement +org.apache.maven.repository.internal.relocation.UserPropertiesArtifactRelocationSource=GuardLogStatement +org.apache.maven.repository.internal.scopes.Maven3ScopeManagerConfiguration=LooseCoupling +org.apache.maven.repository.internal.scopes.Maven4ScopeManagerConfiguration=LooseCoupling +org.apache.maven.repository.internal.type.DefaultType=MissingOverride +org.apache.maven.repository.legacy.DefaultUpdateCheckManager=UnusedLocalVariable,GuardLogStatement,UseTryWithResources +org.apache.maven.repository.legacy.DefaultWagonManager=UnusedFormalParameter,GuardLogStatement +org.apache.maven.repository.legacy.LegacyRepositorySystem=UnnecessaryFullyQualifiedName,MissingOverride,GuardLogStatement,AvoidReassigningParameters +org.apache.maven.repository.legacy.MavenArtifact=MissingOverride +org.apache.maven.repository.legacy.TransferListenerAdapter=MissingOverride +org.apache.maven.repository.legacy.UnknownRepositoryLayout=MissingOverride +org.apache.maven.repository.legacy.metadata.AbstractArtifactMetadata=MissingOverride +org.apache.maven.repository.legacy.metadata.DefaultMetadataResolutionRequest=MissingOverride +org.apache.maven.repository.legacy.metadata.MetadataResolutionRequest=MissingOverride +org.apache.maven.repository.legacy.repository.DefaultArtifactRepositoryFactory=MissingOverride,AvoidReassigningParameters +org.apache.maven.repository.legacy.resolver.DefaultLegacyArtifactCollector=CollapsibleIfStatements,MissingOverride,AvoidReassigningParameters,LooseCoupling,GuardLogStatement +org.apache.maven.repository.legacy.resolver.conflict.DefaultConflictResolverFactory=MissingOverride,PreserveStackTrace +org.apache.maven.repository.legacy.resolver.conflict.FarthestConflictResolver=MissingOverride +org.apache.maven.repository.legacy.resolver.conflict.NearestConflictResolver=MissingOverride +org.apache.maven.repository.legacy.resolver.conflict.NewestConflictResolver=MissingOverride +org.apache.maven.repository.legacy.resolver.conflict.OldestConflictResolver=MissingOverride +org.apache.maven.repository.legacy.resolver.transform.AbstractVersionTransformation=MissingOverride,GuardLogStatement +org.apache.maven.repository.legacy.resolver.transform.DefaultArtifactTransformationManager=MissingOverride +org.apache.maven.repository.legacy.resolver.transform.LatestArtifactTransformation=MissingOverride +org.apache.maven.repository.legacy.resolver.transform.SnapshotTransformation=UselessParentheses,MissingOverride,GuardLogStatement +org.apache.maven.repository.metadata.ArtifactMetadata=UnusedFormalParameter +org.apache.maven.repository.metadata.ClasspathContainer=MissingOverride,UseCollectionIsEmpty +org.apache.maven.repository.metadata.ClasspathGraphVisitor=UseCollectionIsEmpty +org.apache.maven.repository.metadata.DefaultClasspathTransformation=MissingOverride +org.apache.maven.repository.metadata.DefaultGraphConflictResolutionPolicy=MissingOverride +org.apache.maven.repository.metadata.DefaultGraphConflictResolver=UnusedFormalParameter,MissingOverride,LooseCoupling,UseCollectionIsEmpty +org.apache.maven.repository.metadata.MetadataGraph=UnusedFormalParameter,LooseCoupling,UseCollectionIsEmpty +org.apache.maven.repository.metadata.MetadataGraphEdge=OverrideBothEqualsAndHashcode,UselessParentheses,UnusedAssignment +org.apache.maven.repository.metadata.MetadataGraphVertex=MissingOverride +org.apache.maven.repository.metadata.MetadataTreeNode=MethodReturnsInternalArray,UseVarargs,ArrayIsStoredDirectly +org.apache.maven.resolver.Key=MissingOverride +org.apache.maven.resolver.MavenChainedWorkspaceReader=LooseCoupling +org.apache.maven.rtinfo.internal.DefaultRuntimeInformation=GuardLogStatement +org.apache.maven.session.scope.internal.SessionScope=MissingOverride +org.apache.maven.settings.DefaultMavenSettingsBuilder=UnnecessaryFullyQualifiedName,MissingOverride +org.apache.maven.settings.building.DefaultSettingsBuilder=UnusedFormalParameter,AvoidReassigningParameters +org.apache.maven.settings.building.DefaultSettingsProblemCollector=AvoidReassigningParameters +org.apache.maven.settings.crypto.DefaultSettingsDecrypter=AvoidReassigningLoopVariables +org.apache.maven.slf4j.DefaultLogLevelRecorder=CollapsibleIfStatements,AvoidBranchingStatementAsLastInLoop +org.apache.maven.slf4j.MavenBaseLogger=MissingOverride +org.apache.maven.slf4j.MavenServiceProvider=MissingOverride +org.apache.maven.slf4j.MavenSimpleLogger=MissingOverride +org.apache.maven.slf4j.SimpleLoggerConfiguration=GuardLogStatement,UselessParentheses +org.apache.maven.toolchain.DefaultToolchainsBuilder=MissingOverride +org.apache.maven.toolchain.building.DefaultToolchainsBuilder=UnusedFormalParameter,AvoidReassigningParameters +org.apache.maven.toolchain.java.JavaToolchainFactory=MissingOverride +org.apache.maven.toolchain.java.JavaToolchainImpl=MissingOverride +org.eclipse.sisu.plexus.PlexusXmlBeanConverter=MissingOverride,GuardLogStatement,PreserveStackTrace +org.fusesource.jansi.Ansi=AvoidStringBufferField,LooseCoupling,UseVarargs Review Comment: not in the code base -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org