desruisseaux commented on code in PR #2347:
URL: https://github.com/apache/maven/pull/2347#discussion_r2096541896


##########
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolver.java:
##########
@@ -67,6 +67,21 @@
 @Named
 @Singleton
 public class DefaultDependencyResolver implements DependencyResolver {
+    /**
+     * Cache of information about the modules contained in a path element.
+     * This cache is created when first needed. It may be never created.
+     *
+     * <p><b>TODO:</b> This field should not be in this class, because the 
cache should be global to the session.
+     * This field exists here only temporarily, until we clarified where to 
store session-wide caches.</p>
+     *
+     * @see moduleCache()
+     */
+    private PathModularizationCache moduleCache;
+
+    /**
+     * Creates an initially empty resolver.
+     */
+    public DefaultDependencyResolver() {}

Review Comment:
   > Then lets merge and local build should fail when removed, right?
   
   We could make the build fail when the explicit constructor is absent by 
adding the `-Werror` compiler options. But Maven is not ready for that yet. For 
now, this change is just resolving one documentation warning among the many the 
Maven would have if the  `-Xdoclint:all` option was provided.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to