Pankraz76 commented on code in PR #2347:
URL: https://github.com/apache/maven/pull/2347#discussion_r2096412088
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultDependencyResolver.java:
##########
@@ -67,6 +67,21 @@
@Named
@Singleton
public class DefaultDependencyResolver implements DependencyResolver {
+ /**
+ * Cache of information about the modules contained in a path element.
+ * This cache is created when first needed. It may be never created.
+ *
+ * <p><b>TODO:</b> This field should not be in this class, because the
cache should be global to the session.
+ * This field exists here only temporarily, until we clarified where to
store session-wide caches.</p>
+ *
+ * @see moduleCache()
+ */
+ private PathModularizationCache moduleCache;
+
+ /**
+ * Creates an initially empty resolver.
+ */
+ public DefaultDependencyResolver() {}
Review Comment:
> It was added only for making explicit what was implicit before
yes we on the same page. Why we make this? Only if we have 1 constructor
that is NON default, only then this change is required, to provide implicit
default again. **This is not true yet**, therefore its "boilerplate" as its
there, with or without.
This is a change we can see on compiler lvl, or if rare case we use
hibernate having the need for non args constructor like in.
https://stackoverflow.com/questions/2935826/why-does-hibernate-require-no-argument-then
we see this issue on test lvl.
Please provide stacktrace or reproducer proving this code in mandatory by
failing build. Assuming removing the constructor will turn out the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
