Pankraz76 commented on code in PR #2331: URL: https://github.com/apache/maven/pull/2331#discussion_r2087435152
########## .gitignore: ########## @@ -16,4 +16,5 @@ .factorypath .vscode/ repo/ -/*.svg Review Comment: consider sort: <img width="240" alt="image" src="https://github.com/user-attachments/assets/b2b6c89c-eff5-4bc8-865c-6dcf81796f58"; /> ########## .gitignore: ########## @@ -16,4 +16,5 @@ .factorypath .vscode/ repo/ -/*.svg Review Comment: consider natural order: <img width="210" alt="image" src="https://github.com/user-attachments/assets/f895ff74-5b98-46d1-b396-491077f55356"; /> ########## .gitignore: ########## @@ -16,4 +16,5 @@ .factorypath .vscode/ repo/ -/*.svg Review Comment: consider `natural` order: <img width="171" alt="image" src="https://github.com/user-attachments/assets/4eaed4d6-8686-4cf4-8d1e-ef78903edcd5"; /> ########## .gitignore: ########## @@ -16,4 +16,5 @@ .factorypath .vscode/ repo/ -/*.svg Review Comment: consider `natural` order: ########## .gitignore: ########## @@ -16,4 +16,5 @@ .factorypath .vscode/ repo/ -/*.svg Review Comment: consider `natural` order: <img width="496" alt="image" src="https://github.com/user-attachments/assets/c5cd0d71-4571-4b45-9ac8-b035fe319cfb"; /> ########## .gitignore: ########## @@ -16,4 +16,5 @@ .factorypath .vscode/ repo/ -/*.svg Review Comment: consider `natural` order: <img width="573" alt="image" src="https://github.com/user-attachments/assets/dde91694-79fb-40aa-86d3-dbde1329362a"; /> ########## pom.xml: ########## @@ -799,17 +799,37 @@ under the License.</licenseText> <plugin> <groupId>org.apache.maven.plugins</groupId> <artifactId>maven-pmd-plugin</artifactId> + <configuration> + <analysisCache>true</analysisCache> + <analysisCacheLocation>${project.basedir}/.pmd/.cache</analysisCacheLocation> + <minimumPriority>1</minimumPriority> + <printFailingErrors>true</printFailingErrors> + </configuration> <dependencies> <dependency> <groupId>net.sourceforge.pmd</groupId> <artifactId>pmd-core</artifactId> <version>7.12.0</version> </dependency> </dependencies> + <executions> + <execution> + <id>maven-pmd-plugin</id> + <goals> + <goal>check</goal> + </goals> + <phase>verify</phase> + </execution> + </executions> </plugin> </plugins> </pluginManagement> <plugins> + <!-- why profile not working? --> Review Comment: please why is it only applied when declared here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
