Pankraz76 commented on code in PR #2316:
URL: https://github.com/apache/maven/pull/2316#discussion_r2083599649
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultModelXmlFactory.java:
##########
@@ -121,7 +121,7 @@ public void write(XmlWriterRequest<Model> request) throws
XmlWriterException {
Writer writer = request.getWriter();
Function<Object, String> inputLocationFormatter =
request.getInputLocationFormatter();
if (writer == null && outputStream == null && path == null) {
- throw new IllegalArgumentException("writer, outputStream or path
must be non null");
+ throw new IllegalArgumentException("writer, output stream, or path
must be non-null");
Review Comment:
We should focus on communicating the actual business case rather than
exposing low-level implementation details, which are likely to change.
At this stage, it’s more a matter of preference, since the code now clearly
delineates each concern. Code and logging are 2 different worlds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
