desruisseaux commented on code in PR #2236: URL: https://github.com/apache/maven/pull/2236#discussion_r2076690527
########## impl/maven-impl/src/test/java/org/apache/maven/impl/PathSelectorTest.java: ########## @@ -0,0 +1,108 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.maven.impl; + +import java.io.IOException; +import java.nio.file.Files; +import java.nio.file.Path; +import java.util.HashSet; +import java.util.List; +import java.util.Set; + +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.io.TempDir; + +import static org.junit.jupiter.api.Assertions.assertFalse; +import static org.junit.jupiter.api.Assertions.assertTrue; + +public class PathSelectorTest { + /** + * Creates a temporary directory and checks its list of content based on patterns. + * + * @param directory temporary directory where to create a tree + * @throws IOException if an error occurred while creating a temporary file or directory + */ + @Test + public void testTree(final @TempDir Path directory) throws IOException { + Path foo = Files.createDirectory(directory.resolve("foo")); + Path bar = Files.createDirectory(foo.resolve("bar")); + Path biz = Files.createDirectory(directory.resolve("biz")); + Files.createFile(directory.resolve("root.txt")); + Files.createFile(bar.resolve("leaf.txt")); + Files.createFile(biz.resolve("excluded.txt")); + + Set<Path> filtered = filter(directory, ""); + assertFilteredFilesContains(filtered, directory, "root.txt"); + assertFilteredFilesContains(filtered, directory, "foo/bar/leaf.txt"); + assertTrue(filtered.isEmpty(), filtered.toString()); + + filtered = filter(directory, "glob:"); Review Comment: Done with a refactoring that isolated the `filtered` map in another method. While I agree that reusing a variable is a risk of error, creating new variables can (depending on the context) be also error prone, since it introduces a risk of using the wrong variable, especially when blocks are almost copy-and-paste. In this particular case, reusing variables is a way to limit the scope of their value, a little bit like when using `{` … `}` blocks but less safe. Anyway, with the refactoring, this issue is moot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
