desruisseaux commented on PR #2236: URL: https://github.com/apache/maven/pull/2236#issuecomment-2799901325
> We'd need to carefully review the maven-resources-plugins various options and see if they can fit this API. IIRC, there are options such as symlinks following, but there may be others. Yes. This is another aspect replaced by standard Java now, with `java.nio.file.FileVisitOption.FOLLOW_LINKS`. One issue is that it behaves differently than the current Maven for one kind of link specific to the Windows platform: NTFS "junction links". This is handled by a special case in https://github.com/apache/maven-clean-plugin/pull/243. Thankfully, the `maven-cleaner-plugin` has a quite extensive test suite that covers this case among others. Symbolic links are not handled by the `PathSelector` class proposed in this pull request. They need to be handled later, in our use of `java.nio.file.FileVisitor`, which is not part of this PR. I was thinking to address `FileVisitor` in a separated PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
