jira-importer commented on issue #154:
URL: 
https://github.com/apache/maven-install-plugin/issues/154#issuecomment-2771841796

   **[Robert 
Scholte](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=rfscholte)**
 commented
   
   1) The `unattach-artifact` is not the best practice. If you don't want the 
attachment, then don't attach it. Otherwise the project will be in a wrong 
state between 2 goals. Good maven-plugins don't have a delete or detach-option, 
but rather an exclude. I hope you're aware that the maven-source-plugin has an 
[attach](http://maven.apache.org/plugins/maven-source-plugin/jar-mojo.html#attach)
 parameter, which you can set to `false`
      2+3) I know there's an issue for it, but I don't think it will work. 
First of all, `Mojo` is the interface which every goal has to implement. If we 
would add a skip-method, a lot of plugins will probably break. Even though 
there is an `AbstractMojo`, plugins are not required to use it. So Maven would 
have to use reflection to solve this issue. The next problem is that the 
skip-parameter must have a unique property/expression, otherwise you would be 
skipping nothing or everything. So still every `Mojo` has to implement some 
skip-logic.
   
   > all artifacts must be installed to local repository
   > Do you mean that every  developer must run `mvn install` on his system?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to