elharo commented on code in PR #707:
URL: https://github.com/apache/maven-site/pull/707#discussion_r1969784577
##########
content/apt/pom.apt.vm:
##########
@@ -479,31 +479,31 @@ mvn install:install-file -Dfile=non-maven-proj.jar
-DgroupId=some.group -Dartifa
* "<<<1-foo2>>>" \< "<<<1-foo10>>>" (correctly automatically "switching" to
numeric order)
- * "<<<1.foo>>>" = "<<<1-foo>>>" \< "<<<1-1>>>" = "<<<1.1>>>"
+ * "<<<1.foo>>>" = "<<<1-foo>>>" \< "<<<1-1>>>" \< "<<<1.1>>>"
* "<<<1.ga>>>" = "<<<1-ga>>>" = "<<<1-0>>>" = "<<<1.0>>>" = "<<<1>>>"
(removing of trailing "null" values)
* "<<<1-sp>>>" \> "<<<1-ga>>>"
* "<<<1-sp.1>>>" \> "<<<1-ga.1>>>"
- * "<<<1-sp-1>>>" \> "<<<1-ga-1>>>"
+ * "<<<1-sp-1>>>" \< "<<<1-ga-1>>>"
Review Comment:
This feels wrong. Is this what the code does? If so, it might be a mistake.
Do we have a unit test for this?
##########
content/apt/pom.apt.vm:
##########
@@ -479,31 +479,31 @@ mvn install:install-file -Dfile=non-maven-proj.jar
-DgroupId=some.group -Dartifa
* "<<<1-foo2>>>" \< "<<<1-foo10>>>" (correctly automatically "switching" to
numeric order)
- * "<<<1.foo>>>" = "<<<1-foo>>>" \< "<<<1-1>>>" = "<<<1.1>>>"
+ * "<<<1.foo>>>" = "<<<1-foo>>>" \< "<<<1-1>>>" \< "<<<1.1>>>"
Review Comment:
This feels wrong. Do we have a unit test for this?
##########
content/apt/pom.apt.vm:
##########
@@ -436,20 +436,20 @@ mvn install:install-file -Dfile=non-maven-proj.jar
-DgroupId=some.group -Dartifa
* Numeric tokens have the usual ordering of integers.
* Qualifiers are first converted to lower case in the English locale.
- Then they are ordered as by the `compareTo()` method of
`java.lang.String`,
+ Then they are ordered as by the <<<compareTo()>>> method of
<<<java.lang.String>>>,
except for the following tokens which come first in this order:
- "<<<alpha>>>" \< "<<<beta>>>" \< "<<<milestone>>>" \< "<<<rc>>>" =
"<<<cr>>>" \< "<<<snapshot>>>" \< "" = "<<<final>>>" = "<<<ga>>>" \< "<<<sp>>>"
+ "<<<alpha>>>" \< "<<<beta>>>" \< "<<<milestone>>>" \< "<<<rc>>>" =
"<<<cr>>>" \< "<<<snapshot>>>" \< "" = "<<<final>>>" = "<<<ga>>>" =
"<<<release>>>" \< "<<<sp>>>"
Review Comment:
Does this one need m too? I need to check on release
##########
content/apt/pom.apt.vm:
##########
@@ -436,20 +436,20 @@ mvn install:install-file -Dfile=non-maven-proj.jar
-DgroupId=some.group -Dartifa
* Numeric tokens have the usual ordering of integers.
* Qualifiers are first converted to lower case in the English locale.
- Then they are ordered as by the `compareTo()` method of
`java.lang.String`,
+ Then they are ordered as by the <<<compareTo()>>> method of
<<<java.lang.String>>>,
except for the following tokens which come first in this order:
- "<<<alpha>>>" \< "<<<beta>>>" \< "<<<milestone>>>" \< "<<<rc>>>" =
"<<<cr>>>" \< "<<<snapshot>>>" \< "" = "<<<final>>>" = "<<<ga>>>" \< "<<<sp>>>"
+ "<<<alpha>>>" \< "<<<beta>>>" \< "<<<milestone>>>" \< "<<<rc>>>" =
"<<<cr>>>" \< "<<<snapshot>>>" \< "" = "<<<final>>>" = "<<<ga>>>" =
"<<<release>>>" \< "<<<sp>>>"
* the "<<<alpha>>>", "<<<beta>>>" and "<<<milestone>>>" qualifiers can
respectively be shortened to "a", "b" and "m" when directly followed by a
number.
* Alphabetic tokens other than the special cases described above come
before numeric tokens.
- * Alphabetic tokens are compared in a case insensitive fashion in the
{{{https://docs.oracle.com/javase/8/docs/api/java/util/Locale.html#ENGLISH}English
locale}}}. For example, "A" and "a" are treated the same as are "i" and "I"
and "é" and "É".
+ * Alphabetic tokens are compared in a case insensitive fashion in the
{{{https://docs.oracle.com/javase/8/docs/api/java/util/Locale.html#ENGLISH}English
locale}}. For example, "<<<A>>>" and "<<<a>>>" are treated the same as are
"<<<i>>>" and "<<<I>>>" and "<<<é>>>" and "<<<É>>>".
* else "<<<.qualifier>>>" = "<<<-qualifier>>>" \< "<<<-number>>>" \<
"<<<.number>>>"
- * <<<alpha>>> = <<<a>>> < <<<beta>>> = <<<b>>> < <<<milestone>>> = <<<m>>> <
<<<rc>>> = <<<cr>>> < <<<snapshot>>> < '<<<>>>' = <<<final>>> = <<<ga>>> =
<<<release>>> \< <<<sp>>>
+ * <<<alpha>>> \< <<<a1>>> \< <<<beta>>> \< <<<b1>>> \< <<<milestone>>> \<
<<<m1>>> \< <<<rc>>> = <<<cr>>> \< <<<snapshot>>> \< <<<>>> = <<<final>>> =
<<<ga>>> = <<<release>>> \< <<<sp>>>
Review Comment:
Why ml instead of m?
##########
content/apt/pom.apt.vm:
##########
@@ -479,31 +479,31 @@ mvn install:install-file -Dfile=non-maven-proj.jar
-DgroupId=some.group -Dartifa
* "<<<1-foo2>>>" \< "<<<1-foo10>>>" (correctly automatically "switching" to
numeric order)
- * "<<<1.foo>>>" = "<<<1-foo>>>" \< "<<<1-1>>>" = "<<<1.1>>>"
+ * "<<<1.foo>>>" = "<<<1-foo>>>" \< "<<<1-1>>>" \< "<<<1.1>>>"
* "<<<1.ga>>>" = "<<<1-ga>>>" = "<<<1-0>>>" = "<<<1.0>>>" = "<<<1>>>"
(removing of trailing "null" values)
* "<<<1-sp>>>" \> "<<<1-ga>>>"
* "<<<1-sp.1>>>" \> "<<<1-ga.1>>>"
- * "<<<1-sp-1>>>" \> "<<<1-ga-1>>>"
+ * "<<<1-sp-1>>>" \< "<<<1-ga-1>>>"
* "<<<1-a1>>>" = "<<<1-alpha-1>>>"
* "<<<1.0-alpha1>>>" = "<<<1.0-ALPHA1>>>" (case insensitivity)
- * "<<<1.7>>>" \> "1.K"
+ * "<<<1.7>>>" \> "<<<1.K>>>"
- * "<<5.zebra>>>" \> "5.aardvark"
+ * "<<<5.zebra>>>" \> "<<<5.aardvark>>>"
- * "<<1.α>>>" \> "1.b" (Note the Greek letter alpha.)
+ * "<<<1.α>>>" \> "<<<1.b>>>" (Note the Greek letter alpha.)
Note: Contrary to what was stated in some design documents, for version
order, snapshots are not treated differently than releases or any other
qualifier.
Note: As <<<2.0-rc1>>> \< <<<2.0>>>, the version requirement <<<[1.0,2.0)>>>
excludes <<<2.0>>> but includes version <<<2.0-rc1>>>, which is contrary to
what most people expect. In addition, Gradle interprets it differently,
resulting in different dependency trees for the same POM.
- If the intention is to restrict it to <1.*> versions, the better version
requirement is <<<[1,1.999999)>>>.
+ If the intention is to restrict it to <<<1.*>>> versions, the better version
requirement is <<<[1,1.999999)>>> or <<<[1,2alpha)>>>.
Review Comment:
1.2alpha might simply be the better choice here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
