Vampire commented on code in PR #707: URL: https://github.com/apache/maven-site/pull/707#discussion_r1970221705
########## content/apt/pom.apt.vm: ########## @@ -479,31 +479,31 @@ mvn install:install-file -Dfile=non-maven-proj.jar -DgroupId=some.group -Dartifa * "<<<1-foo2>>>" \< "<<<1-foo10>>>" (correctly automatically "switching" to numeric order) - * "<<<1.foo>>>" = "<<<1-foo>>>" \< "<<<1-1>>>" = "<<<1.1>>>" + * "<<<1.foo>>>" = "<<<1-foo>>>" \< "<<<1-1>>>" \< "<<<1.1>>>" * "<<<1.ga>>>" = "<<<1-ga>>>" = "<<<1-0>>>" = "<<<1.0>>>" = "<<<1>>>" (removing of trailing "null" values) * "<<<1-sp>>>" \> "<<<1-ga>>>" * "<<<1-sp.1>>>" \> "<<<1-ga.1>>>" - * "<<<1-sp-1>>>" \> "<<<1-ga-1>>>" + * "<<<1-sp-1>>>" \< "<<<1-ga-1>>>" Review Comment: I don't know, I just corrected the docs to show what the code does. Due to the described and implemented algorithm the `ga` is stripped as it is followed by a hypen (instead of dot like in the line above it). > Then, starting from the end of the version, the trailing "null" values (0, "", "final", "ga") are trimmed. This process is repeated at each remaining hyphen from end to start. So `1-ga-1` becomes `1-1` and `1-1` is greater than `1-sp-1`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
