elharo commented on code in PR #694:
URL: https://github.com/apache/maven-site/pull/694#discussion_r1962271860
##########
content/apt/guides/mini/guide-configuring-plugins.apt:
##########
@@ -47,6 +47,12 @@ Guide to Configuring Plug-ins
{{{/ref/current/maven-model/maven.html#class_plugin}information}}:
<<<groupId>>>, <<<artifactId>>> and <<<version>>>.
+ However, there is a default <<<groupId>>> defined.
+ If no <<<groupId>>> is defined for a plugin in the <<<build>>> or
<<<reporting>>> section of POM file, the value <<<org.apache.maven.plugins>>>
is used to find the plugin.
+ This means that Maven assumes an official Maven plugin will be
used.<<<groupId>>>s
+ If a plugin is called from the command line without a fully qualified name,
for example <<<mvn versions:set>>>, Maven searches for plugins with the
<<<org.apache.maven.plugins>>> or <<<org.codehaus.mojo>>>.
Review Comment:
with the <<<org.apache.maven.plugins>>> or <<<org.codehaus.mojo>>>
There is a word missing here. Maybe "group ID"?
##########
content/apt/guides/mini/guide-configuring-plugins.apt:
##########
@@ -47,6 +47,12 @@ Guide to Configuring Plug-ins
{{{/ref/current/maven-model/maven.html#class_plugin}information}}:
<<<groupId>>>, <<<artifactId>>> and <<<version>>>.
+ However, there is a default <<<groupId>>> defined.
+ If no <<<groupId>>> is defined for a plugin in the <<<build>>> or
<<<reporting>>> section of POM file, the value <<<org.apache.maven.plugins>>>
is used to find the plugin.
+ This means that Maven assumes an official Maven plugin will be
used.<<<groupId>>>s
+ If a plugin is called from the command line without a fully qualified name,
for example <<<mvn versions:set>>>, Maven searches for plugins with the
<<<org.apache.maven.plugins>>> or <<<org.codehaus.mojo>>>.
+ For more information, see
{{{/guides/introduction/introduction-to-plugin-prefix-mapping.html}Introduction
to Plugin Prefix Resolution}}.
+
<<Important Note>>: Always define the version of each plugin used to
guarantee
Review Comment:
delete "used"
##########
content/apt/pom.apt.vm:
##########
@@ -983,6 +983,10 @@ Display parameters as parsed by Maven (in canonical form
and as a list of tokens
</project>
+------------------------------------------+
+ Plugins are also identified by coordinates.
+ Unlike dependencies, there is a default <<<groupId>>> definied for plugins.
Review Comment:
delete "definied"
##########
content/apt/guides/mini/guide-configuring-plugins.apt:
##########
@@ -47,6 +47,12 @@ Guide to Configuring Plug-ins
{{{/ref/current/maven-model/maven.html#class_plugin}information}}:
<<<groupId>>>, <<<artifactId>>> and <<<version>>>.
+ However, there is a default <<<groupId>>> defined.
+ If no <<<groupId>>> is defined for a plugin in the <<<build>>> or
<<<reporting>>> section of POM file, the value <<<org.apache.maven.plugins>>>
is used to find the plugin.
+ This means that Maven assumes an official Maven plugin will be
used.<<<groupId>>>s
+ If a plugin is called from the command line without a fully qualified name,
for example <<<mvn versions:set>>>, Maven searches for plugins with the
<<<org.apache.maven.plugins>>> or <<<org.codehaus.mojo>>>.
Review Comment:
also the plexus bit contradicts the sentence above which does not mention
plexus. You can probably remove or combine one of these sentences anyway.
##########
content/apt/guides/mini/guide-configuring-plugins.apt:
##########
@@ -47,6 +47,12 @@ Guide to Configuring Plug-ins
{{{/ref/current/maven-model/maven.html#class_plugin}information}}:
<<<groupId>>>, <<<artifactId>>> and <<<version>>>.
+ However, there is a default <<<groupId>>> defined.
+ If no <<<groupId>>> is defined for a plugin in the <<<build>>> or
<<<reporting>>> section of POM file, the value <<<org.apache.maven.plugins>>>
is used to find the plugin.
Review Comment:
"the value <<<org.apache.maven.plugins>>> is used to find the plugin." Maven
uses the group ID <<<org.apache.maven.plugins>>>
##########
content/apt/guides/mini/guide-configuring-plugins.apt:
##########
@@ -47,6 +47,12 @@ Guide to Configuring Plug-ins
{{{/ref/current/maven-model/maven.html#class_plugin}information}}:
<<<groupId>>>, <<<artifactId>>> and <<<version>>>.
+ However, there is a default <<<groupId>>> defined.
+ If no <<<groupId>>> is defined for a plugin in the <<<build>>> or
<<<reporting>>> section of POM file, the value <<<org.apache.maven.plugins>>>
is used to find the plugin.
+ This means that Maven assumes an official Maven plugin will be
used.<<<groupId>>>s
Review Comment:
delete <<<groupId>>>s
##########
content/apt/guides/mini/guide-configuring-plugins.apt:
##########
@@ -47,6 +47,12 @@ Guide to Configuring Plug-ins
{{{/ref/current/maven-model/maven.html#class_plugin}information}}:
<<<groupId>>>, <<<artifactId>>> and <<<version>>>.
+ However, there is a default <<<groupId>>> defined.
Review Comment:
delete this sentence
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
