elharo commented on code in PR #694:
URL: https://github.com/apache/maven-site/pull/694#discussion_r1961840340
##########
content/apt/guides/mini/guide-configuring-plugins.apt:
##########
@@ -47,6 +47,12 @@ Guide to Configuring Plug-ins
{{{/ref/current/maven-model/maven.html#class_plugin}information}}:
<<<groupId>>>, <<<artifactId>>> and <<<version>>>.
+ However, there is a default <<<groupId>>> defined in the Maven
{{{/xsd/maven-4.0.0.xsd}POM 4.0.0 XSD}} and later.
Review Comment:
The XSD is informative. I don't think it's used in processing. There's no
reaosn to mention it here.
##########
content/apt/guides/mini/guide-configuring-plugins.apt:
##########
@@ -47,6 +47,12 @@ Guide to Configuring Plug-ins
{{{/ref/current/maven-model/maven.html#class_plugin}information}}:
<<<groupId>>>, <<<artifactId>>> and <<<version>>>.
+ However, there is a default <<<groupId>>> defined in the Maven
{{{/xsd/maven-4.0.0.xsd}POM 4.0.0 XSD}} and later.
+ If no <<<groupId>>> is defined for a plugin in the <<<build>>> or
<<<reporting>>> section of POM file, the value <<<org.apache.maven.plugins>>>
is used to find the plugin.
+ This means that Maven assumes an official Maven plugin shall be used.
Review Comment:
shall --> will
##########
content/apt/guides/mini/guide-configuring-plugins.apt:
##########
@@ -47,6 +47,12 @@ Guide to Configuring Plug-ins
{{{/ref/current/maven-model/maven.html#class_plugin}information}}:
<<<groupId>>>, <<<artifactId>>> and <<<version>>>.
+ However, there is a default <<<groupId>>> defined in the Maven
{{{/xsd/maven-4.0.0.xsd}POM 4.0.0 XSD}} and later.
+ If no <<<groupId>>> is defined for a plugin in the <<<build>>> or
<<<reporting>>> section of POM file, the value <<<org.apache.maven.plugins>>>
is used to find the plugin.
+ This means that Maven assumes an official Maven plugin shall be used.
+ If a plugin is called from the command line without full qualified name, for
example <<<mvn versions:set>>>, Maven searches for plugins defined within the
<<<groupId>>>s <<<org.apache.maven.plugins>>> and <<<org.codehaus.mojo>>>.
Review Comment:
a fully qualified
##########
content/apt/pom.apt.vm:
##########
@@ -983,6 +983,9 @@ Display parameters as parsed by Maven (in canonical form
and as a list of tokens
</project>
+------------------------------------------+
+ Plugins are also identified by coordinates.
+ In difference to dependencies, there is a default <<<groupId>>> definied for
plugins, see {{{/guides/mini/guide-configuring-plugins.html}configuring
plugins.}}
Review Comment:
In difference to --> Unlike
"there is a default <<<groupId>>> definied for plugins, see" --> "there is a
default <<<groupId>>> for plugins. See"
configuring plugins --> "Configuring Plugins"
##########
content/apt/guides/mini/guide-configuring-plugins.apt:
##########
@@ -47,6 +47,12 @@ Guide to Configuring Plug-ins
{{{/ref/current/maven-model/maven.html#class_plugin}information}}:
<<<groupId>>>, <<<artifactId>>> and <<<version>>>.
+ However, there is a default <<<groupId>>> defined in the Maven
{{{/xsd/maven-4.0.0.xsd}POM 4.0.0 XSD}} and later.
+ If no <<<groupId>>> is defined for a plugin in the <<<build>>> or
<<<reporting>>> section of POM file, the value <<<org.apache.maven.plugins>>>
is used to find the plugin.
+ This means that Maven assumes an official Maven plugin shall be used.
+ If a plugin is called from the command line without full qualified name, for
example <<<mvn versions:set>>>, Maven searches for plugins defined within the
<<<groupId>>>s <<<org.apache.maven.plugins>>> and <<<org.codehaus.mojo>>>.
+ For more information see the
{{{/guides/introduction/introduction-to-plugin-prefix-mapping.html}introduction
to Plugin Prefix Resolution}}.
Review Comment:
comma after information
see the
{{{/guides/introduction/introduction-to-plugin-prefix-mapping.html}introduction
to Plugin Prefix Resolution}} --> see
{{{/guides/introduction/introduction-to-plugin-prefix-mapping.html}Introduction
to Plugin Prefix Resolution}}
##########
content/apt/guides/mini/guide-configuring-plugins.apt:
##########
@@ -47,6 +47,12 @@ Guide to Configuring Plug-ins
{{{/ref/current/maven-model/maven.html#class_plugin}information}}:
<<<groupId>>>, <<<artifactId>>> and <<<version>>>.
+ However, there is a default <<<groupId>>> defined in the Maven
{{{/xsd/maven-4.0.0.xsd}POM 4.0.0 XSD}} and later.
+ If no <<<groupId>>> is defined for a plugin in the <<<build>>> or
<<<reporting>>> section of POM file, the value <<<org.apache.maven.plugins>>>
is used to find the plugin.
+ This means that Maven assumes an official Maven plugin shall be used.
+ If a plugin is called from the command line without full qualified name, for
example <<<mvn versions:set>>>, Maven searches for plugins defined within the
<<<groupId>>>s <<<org.apache.maven.plugins>>> and <<<org.codehaus.mojo>>>.
Review Comment:
a noun is missing at the end
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
