gnodet commented on code in PR #2082:
URL: https://github.com/apache/maven/pull/2082#discussion_r1939643819
##########
impl/maven-cli/src/main/java/org/apache/maven/cling/invoker/LookupInvoker.java:
##########
@@ -308,13 +309,13 @@ protected void createTerminal(C context) {
if (context.terminal == null) {
MessageUtils.systemInstall(
builder -> {
- builder.streams(
- context.invokerRequest.in().orElse(null),
- context.invokerRequest.out().orElse(null));
-
builder.systemOutput(TerminalBuilder.SystemOutput.ForcedSysOut);
- // The exec builder suffers from
https://github.com/jline/jline3/issues/1098
- // We could re-enable it when fixed to provide support
for non-standard architectures,
- // for which JLine does not provide any native library.
+ if (context.invokerRequest.embedded()) {
+ builder.streams(
+
context.invokerRequest.stdIn().orElse(InputStream.nullInputStream()),
+
context.invokerRequest.stdOut().orElse(System.out));
Review Comment:
Why not `OutputStream.nullOuputStream()` ? If the user does not want output,
let's not print it out.
Else, it will be difficult to work around. And user can simply pass in
`System.out` if he wants.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
