gnodet commented on code in PR #2082:
URL: https://github.com/apache/maven/pull/2082#discussion_r1939451296


##########
impl/maven-executor/src/main/java/org/apache/maven/cling/executor/forked/ForkedMavenExecutor.java:
##########
@@ -87,12 +87,16 @@ protected void validate(ExecutorRequest executorRequest) 
throws ExecutorExceptio
 
     @Nullable
     protected Consumer<Process> wrapStdouterrConsumer(ExecutorRequest 
executorRequest) {
-        if (executorRequest.stdoutConsumer().isEmpty()
+        if (executorRequest.stdinProvider().isEmpty()
+                && executorRequest.stdoutConsumer().isEmpty()
                 && executorRequest.stderrConsumer().isEmpty()) {
             return null;
         } else {
             return p -> {
                 try {
+                    if (executorRequest.stdinProvider().isPresent()) {
+                        
executorRequest.stdinProvider().orElseThrow().transferTo(p.getOutputStream());

Review Comment:
   Why do we consume stdin and write it to stdout ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to