elharo commented on code in PR #2025:
URL: https://github.com/apache/maven/pull/2025#discussion_r1904244318
##########
impl/maven-logging/src/main/java/org/apache/maven/slf4j/MavenBaseLogger.java:
##########
@@ -146,6 +147,7 @@
*/
public class MavenBaseLogger extends LegacyAbstractLogger {
+ @Serial
Review Comment:
Honestly there is none. It's just something developers put in 20 years ago
because maybe it would help someone somewhere. Java object serialization isn't
much used these days, and Brian Goetz uses it as a canonical example of a
really interesting antipattern in software design and development:
https://www.youtube.com/watch?v=n6K_8s3Sx4s
https://www.youtube.com/watch?v=dOgfWXw9VrI&t=1957s
What can I say? It was 1997 and none of us really knew what we were doing
yet, Sun included.
Interestingly, some of the initialization issues that make Java
serialization dangerous are the same reasons we should move away from field
injection with Plexus to constructor injection with Guice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
