Stellar1999 commented on code in PR #2025:
URL: https://github.com/apache/maven/pull/2025#discussion_r1904167919


##########
impl/maven-logging/src/main/java/org/apache/maven/slf4j/MavenBaseLogger.java:
##########
@@ -146,6 +147,7 @@
  */
 public class MavenBaseLogger extends LegacyAbstractLogger {
 
+    @Serial

Review Comment:
   Maybe only the SLF4J team knows the exact use case. My guess is that it 
might involve transmitting logger objects over a network. However, if 
AbstractClass implements Serializable, I think we should also define a 
serialVersionUID.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to