slawekjaranowski commented on code in PR #165:
URL: https://github.com/apache/maven-parent/pull/165#discussion_r1899649167


##########
pom.xml:
##########
@@ -944,8 +944,7 @@ under the License.
 
   <properties>
     <javaVersion>8</javaVersion>
-    <maven.compiler.source>${javaVersion}</maven.compiler.source>
-    <maven.compiler.target>${javaVersion}</maven.compiler.target>
+    <maven.compiler.release>${javaVersion}</maven.compiler.release>

Review Comment:
   Should we left old properties and allow to m-compiler-p to use proper one?
   
   What java version will be used by m-compiler-p when we have only 
maven.compiler.release and build on JDK 8?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to